Commit 805b242
fix(pro-dummy): guard sockPort parseInt with || 3035 fallback
`parseInt(undefined, 10)` returns NaN, which would be silently passed
to ReactRefreshWebpackPlugin if devServer.port was ever absent. Falling
back to Shakapacker's default port (3035) surfaces a misconfiguration
as a wrong port rather than silent NaN. Applied to both the Pro dummy
and the execjs-compatible dummy webpack configs for consistency.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 30fcbe8 commit 805b242
2 files changed
Lines changed: 6 additions & 2 deletions
File tree
- react_on_rails_pro/spec
- dummy/config/webpack
- execjs-compatible-dummy/config/webpack
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
0 commit comments