Skip to content

Commit f8559d0

Browse files
committed
Fix GitHub Actions release permissions and update README to target MinGW
1 parent 8dc12d0 commit f8559d0

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ on:
66
- 'v*'
77
workflow_dispatch:
88

9+
permissions:
10+
contents: write
11+
912
jobs:
1013
build-windows:
1114
runs-on: windows-latest

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ This emulator is built specifically for **Windows 11**.
1919
### Requirements
2020
- **OS**: Windows 11
2121
- **CMake**: Version 3.20 or higher
22-
- **Compiler**: MSVC (Visual Studio 2019/2022) or any compatible C++20 compiler on Windows.
22+
- **Compiler**: MinGW (GCC) or any compatible C++20 compiler on Windows.
2323

2424
### Build from source
2525
Open your terminal (Command Prompt / PowerShell) and run the following commands:
@@ -30,14 +30,14 @@ cmake -B build
3030
# 2. Compile the executable
3131
cmake --build build
3232
```
33-
*(Note: By default on Visual Studio/MSVC, the executable will be located at `build\Debug\gb_emulator.exe`. If you want an optimized version, run `cmake --build build --config Release` and find it in `build\Release\gb_emulator.exe`.)*
33+
*(Note: Using MinGW, the compiled executable will be located directly at `build\gb_emulator.exe`. If you are using MSVC on Windows, it may be placed in a subdirectory like `build\Debug\gb_emulator.exe` or `build\Release\gb_emulator.exe` depending on your config.)*
3434

3535
### Running the Emulator
3636
You can launch the emulator in two ways:
3737
1. **Direct Launch**: Simply double-click `gb_emulator.exe`. Once the window opens, you can drag and drop any `.gb` ROM file into the emulator window to start playing.
3838
2. **Command Line**: Run the executable and pass the ROM file path as an argument.
3939
```bat
40-
.\build\Debug\gb_emulator.exe "path/to/your/game.gb"
40+
.\build\gb_emulator.exe "path/to/your/game.gb"
4141
```
4242

4343
## ROMs

0 commit comments

Comments
 (0)