fixup: remove skips

Author: Will Toozs

tests/functional/kmip/serverside_encryption.js

@@ -162,8 +162,7 @@ describe('KMIP backed server-side encryption', () => {
         });
     });
 
-    // TODO CLDSRV-431 remove skip
-    it.skip('should allow object copy with SSE header in encrypted bucket', done => {
+    it('should allow object copy with SSE header in encrypted bucket', done => {
         async.waterfall([
             next => _createBucket(bucketName, false, err => next(err)),
             next => _putObject(bucketName, objectName, false, err => next(err)),
@@ -176,8 +175,7 @@ describe('KMIP backed server-side encryption', () => {
             done();
         });
     });
-    // TODO CLDSRV-431 remove skip
-    it.skip('should allow creating mpu with SSE header ' +
+    it('should allow creating mpu with SSE header ' +
         'in encrypted bucket', done => {
         async.waterfall([
             next => _createBucket(bucketName, true, err => next(err)),

tests/multipleBackend/multipartUpload.js

@@ -320,8 +320,7 @@ function abortMultipleMpus(backendsInfo, callback) {
         callback();
     });
 }
-// TODO CLDSRV-431 remove skip
-describe.skip('Multipart Upload API with AWS Backend', function mpuTestSuite() {
+describe('Multipart Upload API with AWS Backend', function mpuTestSuite() {
     this.timeout(60000);
 
     beforeEach(done => {

tests/multipleBackend/objectCopy.js

@@ -71,8 +71,7 @@ function copySetup(params, cb) {
             callback),
     ], err => cb(err));
 }
-// TODO CLDSRV-431 remove skip
-describe.skip('ObjectCopy API with multiple backends', () => {
+describe('ObjectCopy API with multiple backends', () => {
     before(() => {
         cleanup();
     });

tests/multipleBackend/objectPutCopyPart.js

@@ -33,8 +33,7 @@ const awsLocation2 = 'awsbackend2';
 const awsLocationMismatch = 'awsbackendmismatch';
 const partETag = 'be747eb4b75517bf6b3cf7c5fbb62f3a';
 
-// TODO CLDSRV-431 reenable
-// const describeSkipIfE2E = process.env.S3_END_TO_END ? describe.skip : describe;
+const describeSkipIfE2E = process.env.S3_END_TO_END ? describe.skip : describe;
 
 function getSourceAndDestKeys() {
     const timestamp = Date.now();
@@ -175,9 +174,7 @@ function assertPartList(partList, uploadId) {
     assert.strictEqual(partList.Parts[0].Size, 11);
 }
 
-// TODO CLDSRV-431 remove skip
-// describeSkipIfE2E('ObjectCopyPutPart API with multiple backends',
-describe.skip('ObjectCopyPutPart API with multiple backends',
+describeSkipIfE2E('ObjectCopyPutPart API with multiple backends',
     function testSuite() {
         this.timeout(60000);
 

tests/multipleBackend/objectPutPart.js

@@ -37,8 +37,7 @@ const md5Hash2 = crypto.createHash('md5');
 const calculatedHash1 = md5Hash1.update(body1).digest('hex');
 const calculatedHash2 = md5Hash2.update(body2).digest('hex');
 
-// TODO CLDSRV-431 reenable
-// const describeSkipIfE2E = process.env.S3_END_TO_END ? describe.skip : describe;
+const describeSkipIfE2E = process.env.S3_END_TO_END ? describe.skip : describe;
 
 function _getOverviewKey(objectKey, uploadId) {
     return `overview${splitter}${objectKey}${splitter}${uploadId}`;
@@ -169,9 +168,7 @@ function listAndAbort(uploadId, calculatedHash2, objectName, done) {
         });
     });
 }
-// TODO CLDSRV-431 remove skip
-// describeSkipIfE2E('objectPutPart API with multiple backends',
-describe.skip('objectPutPart API with multiple backends',
+describeSkipIfE2E('objectPutPart API with multiple backends',
     function testSuite() {
         this.timeout(5000);
 

tests/unit/api/bucketACLauth.js

@@ -18,8 +18,7 @@ const bucket = new BucketInfo('niftyBucket', ownerCanonicalId,
     authInfo.getAccountDisplayName(), creationDate);
 const log = new DummyRequestLogger();
 
-// TODO CLDSRV-431 remove skip
-describe.skip('bucket authorization for bucketGet, bucketHead, ' +
+describe('bucket authorization for bucketGet, bucketHead, ' +
     'objectGet, and objectHead', () => {
     // Reset the bucket ACLs
     afterEach(() => {

tests/unit/api/bucketDelete.js

@@ -129,8 +129,7 @@ describe('bucketDelete API', () => {
         });
     });
 
-    // TODO CLDSRV-431 remove skip
-    it.skip('should not return an error if the bucket has an initiated mpu',
+    it('should not return an error if the bucket has an initiated mpu',
     done => {
         bucketPut(authInfo, testRequest, log, err => {
             assert.strictEqual(err, null);
@@ -160,13 +159,11 @@ describe('bucketDelete API', () => {
         });
     });
 
-    // TODO CLDSRV-431 remove skip
-    it.skip('should delete a bucket even if the bucket has ongoing mpu',
+    it('should delete a bucket even if the bucket has ongoing mpu',
         done => createMPU(testRequest, initiateRequest, false, done));
 
-    // TODO CLDSRV-431 remove skip
     // if only part object (and no overview objects) is in mpu shadow bucket
-    it.skip('should delete a bucket even if the bucket has an orphan part',
+    it('should delete a bucket even if the bucket has an orphan part',
         done => createMPU(testRequest, initiateRequest, true, done));
 
 

tests/unit/api/bucketHead.js

@@ -16,8 +16,7 @@ const testRequest = {
     url: '/',
     iamAuthzResults: false,
 };
-// TODO CLDSRV-431 remove skip
-describe.skip('bucketHead API', () => {
+describe('bucketHead API', () => {
     beforeEach(() => {
         cleanup();
     });

tests/unit/api/deleteMarker.js

@@ -99,8 +99,7 @@ const undefHeadersExpected = [
     'expires',
 ];
 
-// TODO CLDSRV-431 remove skip
-describe.skip('delete marker creation', () => {
+describe('delete marker creation', () => {
     beforeEach(done => {
         cleanup();
         bucketPut(authInfo, testPutBucketRequest, log, err => {

tests/unit/api/deletedFlagBucket.js

@@ -105,8 +105,7 @@ function confirmDeleted(done) {
     });
 }
 
-// TODO CLDSRV-431 remove skip
-describe.skip('deleted flag bucket handling', () => {
+describe('deleted flag bucket handling', () => {
     beforeEach(done => {
         cleanup();
         const bucketMD = new BucketInfo(bucketName, canonicalID,