Skip to content

Commit 935335e

Browse files
authored
Merge pull request #6 from jckirton/move-autocomplete-to-postprocessing
Move script autocompletes from minification to postprocessing.
2 parents a2ff389 + e4ded7a commit 935335e

3 files changed

Lines changed: 17 additions & 13 deletions

File tree

src/processScript/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,8 @@ export async function processScript(code: string, {
326326
code = generate(file).code
327327

328328
if (shouldMinify)
329-
code = await minify(file, { uniqueId, mangleNames, forceQuineCheats, autocomplete })
329+
// code = await minify(file, { uniqueId, mangleNames, forceQuineCheats, autocomplete })
330+
code = await minify(file, { uniqueId, mangleNames, forceQuineCheats })
330331
else {
331332
traverse(file, {
332333
MemberExpression({ node: memberExpression }) {
@@ -420,7 +421,7 @@ export async function processScript(code: string, {
420421
)
421422
}
422423

423-
code = postprocess(code, uniqueId)
424+
code = postprocess(code, uniqueId, autocomplete)
424425

425426
if (includesIllegalString(code)) {
426427
throw Error(

src/processScript/minify.ts

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ type MinifyOptions = LaxPartial<{
2525
*/
2626
forceQuineCheats: boolean
2727

28-
/** the comment inserted after the function signature */ autocomplete: string
28+
// /** the comment inserted after the function signature */ autocomplete: string
2929
}>
3030

3131
const minifyNumber = async (number: number) => /\$\((?<number>.+)\)/
@@ -40,7 +40,8 @@ const minifyNumber = async (number: number) => /\$\((?<number>.+)\)/
4040
*/
4141
export async function minify(
4242
file: File,
43-
{ uniqueId = `00000000000`, mangleNames = false, forceQuineCheats, autocomplete }: MinifyOptions = {}
43+
// { uniqueId = `00000000000`, mangleNames = false, forceQuineCheats, autocomplete }: MinifyOptions = {}
44+
{ uniqueId = `00000000000`, mangleNames = false, forceQuineCheats }: MinifyOptions = {}
4445
): Promise<string> {
4546
assert(/^\w{11}$/.exec(uniqueId), HERE)
4647

@@ -175,13 +176,13 @@ export async function minify(
175176
.replace(new RegExp(`_${uniqueId}_PROTOTYPE_PROPERTY_`, `g`), `"prototype"`)
176177
.replace(new RegExp(`_${uniqueId}_PROTO_PROPERTY_`, `g`), `"__proto__"`)
177178

178-
if (autocomplete) {
179-
scriptBeforeJSONValueReplacement = spliceString(
180-
scriptBeforeJSONValueReplacement,
181-
`//${autocomplete}\n`,
182-
getFunctionBodyStart(scriptBeforeJSONValueReplacement) + 1
183-
)
184-
}
179+
// if (autocomplete) {
180+
// scriptBeforeJSONValueReplacement = spliceString(
181+
// scriptBeforeJSONValueReplacement,
182+
// `//${autocomplete}\n`,
183+
// getFunctionBodyStart(scriptBeforeJSONValueReplacement) + 1
184+
// )
185+
// }
185186

186187
if (forceQuineCheats == false)
187188
return scriptBeforeJSONValueReplacement
@@ -465,7 +466,8 @@ export async function minify(
465466
if (comment != undefined) {
466467
code = spliceString(
467468
code,
468-
`${autocomplete ? `//${autocomplete}\n` : ``}\n//\t${comment}\t\n`,
469+
// `${autocomplete ? `//${autocomplete}\n` : ``}\n//\t${comment}\t\n`,
470+
`\n//\t${comment}\t\n`,
469471
getFunctionBodyStart(code) + 1
470472
)
471473

src/processScript/postprocess.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
export const postprocess = (code: string, uniqueId: string): string => code
1+
export const postprocess = (code: string, uniqueId: string, autocomplete: string | undefined): string => code
22
.replace(/^function\s*[\w$]+\(/, `function(`)
3+
.replace(/(^.+\{)/, `$1${autocomplete ? `//${autocomplete}` : ``}`)
34
.replace(new RegExp(`\\$${uniqueId}\\$\\\\(?:\\\\)?\\$SC_DOLLAR\\$`, `g`), `S\\C$`)
45
.replace(new RegExp(`\\$${uniqueId}\\$\\\\(?:\\\\)?\\$DB_DOLLAR\\$`, `g`), `D\\B$`)
56
.replace(new RegExp(`\\$${uniqueId}\\$\\\\(?:\\\\)?\\$D\\$`, `g`), `_\\_D_S`)

0 commit comments

Comments
 (0)