Fix SyncConfiguration.toString() (#3792)

Author: cmelchior

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## 2.2.1
 
+### Object Server API Changes (In Beta)
+
+* Fixed `SyncConfiguration.toString()` so it now outputs a correct description instead of an empty string (#3787).
+
 ### Bug fixes
 
 * Added version number to the native library, preventing ReLinker from accidentally loading old code (#3775).

realm/realm-library/src/androidTestObjectServer/java/io/realm/SyncConfigurationTests.java

@@ -391,4 +391,14 @@ public void defaultRxFactory() {
 
         assertNotNull(config.getRxFactory());
     }
+
+    @Test
+    public void toString_nonEmpty() {
+        SyncUser user = createTestUser();
+        String url = "realm://objectserver.realm.io/default";
+        SyncConfiguration config = new SyncConfiguration.Builder(user, url).build();
+
+        String configStr = config.toString();
+        assertTrue(configStr != null && !configStr.isEmpty());
+    }
 }

realm/realm-library/src/androidTestObjectServer/java/io/realm/SyncUserTests.java

@@ -144,4 +144,11 @@ public void getManagementRealm_enforceTLS() throws URISyntaxException {
         managementRealm.close();
     }
 
+    @Test
+    public void toString_returnDescription() {
+        SyncUser user = SyncTestUtils.createTestUser("http://objectserver.realm.io/auth");
+        String str = user.toString();
+        assertTrue(str != null && !str.isEmpty());
+    }
+
 }

realm/realm-library/src/objectServer/java/io/realm/SyncConfiguration.java

@@ -177,8 +177,17 @@ public int hashCode() {
 
     @Override
     public String toString() {
-        StringBuilder stringBuilder = new StringBuilder();
-        // TODO
+        StringBuilder stringBuilder = new StringBuilder(super.toString());
+        stringBuilder.append("\n");
+        stringBuilder.append("serverUrl: " + serverUrl);
+        stringBuilder.append("\n");
+        stringBuilder.append("user: " + user);
+        stringBuilder.append("\n");
+        stringBuilder.append("syncPolicy: " + syncPolicy);
+        stringBuilder.append("\n");
+        stringBuilder.append("errorHandler: " + errorHandler);
+        stringBuilder.append("\n");
+        stringBuilder.append("deleteRealmOnLogout: " + deleteRealmOnLogout);
         return stringBuilder.toString();
     }
 

realm/realm-library/src/objectServer/java/io/realm/SyncUser.java

@@ -408,6 +408,17 @@ public int hashCode() {
         return syncUser.hashCode();
     }
 
+    @Override
+    public String toString() {
+        StringBuilder sb = new StringBuilder("{");
+        sb.append("UserId: ").append(syncUser.getIdentity());
+        sb.append(", AuthUrl: ").append(syncUser.getAuthenticationUrl());
+        sb.append(", IsValid: ").append(isValid());
+        sb.append(", Sessions: ").append(syncUser.getSessions().size());
+        sb.append("}");
+        return sb.toString();
+    }
+
     // Expose internal representation for other package protected classes
     ObjectServerUser getSyncUser() {
         return syncUser;