feat: top directory added

Author: ravindran-dev

cmd/linux-health/main.go

@@ -13,6 +13,7 @@ import (
 )
 
 func main() {
+	// ---- SYSTEM STATS ----
 	stats, err := system.GetSystemStats()
 	if err != nil {
 		fmt.Println("error:", err)
@@ -21,44 +22,48 @@ func main() {
 
 	health := system.GenerateHealth(stats)
 
+	// ---- TOP MEMORY PROCESS ----
 	topName := ""
 	topPID := 0
-	var topMB uint64
+	topMB := uint64(0)
 
-	if topProc, _ := process.TopMemoryProcess(); topProc != nil {
+	topProc, _ := process.TopMemoryProcess()
+	if topProc != nil {
 		topName = topProc.Cmd
 		topPID = topProc.PID
 		topMB = topProc.MemKB / 1024
 	}
 
+	// ---- DISK HOTSPOTS (FAST) ----
 	hotspots := []string{}
-	dirs, _ := disk.TopDirs(os.Getenv("HOME"), 2)
-
+	dirs, _ := disk.TopDirs(os.Getenv("HOME"), 3)
 	for _, d := range dirs {
-		hotspots = append(hotspots, d.Path+" "+d.SizeHuman)
+		hotspots = append(hotspots,
+			fmt.Sprintf("%s %s", d.Path, d.SizeHuman),
+		)
 	}
 
-	// ---- SERVICES ----
-	services := []string{}
-	if failed, _ := service.FailedServices(); len(failed) > 0 {
-		for _, s := range failed {
-			services = append(services, s.Name+" ("+s.State+")")
-		}
+	// ---- FAILED SERVICES ----
+	failedServices := []string{}
+	failed, _ := service.FailedServices()
+	for _, s := range failed {
+		failedServices = append(failedServices,
+			fmt.Sprintf("%s (%s)", s.Name, s.State),
+		)
 	}
 
-	networkState := "inactive"
-	if nets, _ := network.ActiveInterfaces(); len(nets) > 0 {
-		networkState = "active"
-	}
+	// ---- NETWORK ----
+	networkState := network.Summary()
 
+	// ---- OUTPUT ----
 	output.PrintBlock(
 		stats,
 		health,
 		topName,
 		topPID,
 		topMB,
 		networkState,
-		services,
+		failedServices,
 		hotspots,
 	)
 

internal/disk/top_dirs.go

@@ -3,7 +3,6 @@ package disk
 import (
 	"bytes"
 	"os/exec"
-	"sort"
 	"strings"
 )
 
@@ -13,7 +12,7 @@ type DirUsage struct {
 }
 
 func TopDirs(root string, limit int) ([]DirUsage, error) {
-	cmd := exec.Command("du", "-sh", root+"/*")
+	cmd := exec.Command("sh", "-c", "du -sh "+root+"/* 2>/dev/null")
 	var out bytes.Buffer
 	cmd.Stdout = &out
 
@@ -25,27 +24,15 @@ func TopDirs(root string, limit int) ([]DirUsage, error) {
 	var dirs []DirUsage
 
 	for _, line := range lines {
-		line = strings.TrimSpace(line)
-		if line == "" {
-			continue
+		fields := strings.Fields(line)
+		if len(fields) >= 2 {
+			dirs = append(dirs, DirUsage{
+				SizeHuman: fields[0],
+				Path:      fields[1],
+			})
 		}
-
-		parts := strings.Fields(line)
-		if len(parts) < 2 {
-			continue
-		}
-
-		dirs = append(dirs, DirUsage{
-			SizeHuman: parts[0],
-			Path:      parts[1],
-		})
 	}
 
-	// Sort descending by size string (du already sorts roughly)
-	sort.Slice(dirs, func(i, j int) bool {
-		return dirs[i].SizeHuman > dirs[j].SizeHuman
-	})
-
 	if len(dirs) > limit {
 		dirs = dirs[:limit]
 	}

pkg/output/block.go

@@ -2,8 +2,8 @@ package output
 
 import (
 	"fmt"
-
 	"github.com/ravindran-dev/linux-health/internal/system"
+	"strings"
 )
 
 const boxWidth = 40
@@ -41,15 +41,15 @@ func PrintBlock(
 	}
 
 	sep()
+	row("HOTSPOTS:")
 
-	if len(diskHotspots) > 0 {
-		row("HOTSPOTS:")
+	if len(diskHotspots) == 0 {
+		row("  No large directories found")
+	} else {
 		for _, d := range diskHotspots {
 			row("  " + trim(d))
 		}
-		sep()
 	}
-
 	row("SERVICES:")
 	if len(failedServices) == 0 {
 		row("  ✓ No failed services")
@@ -60,7 +60,8 @@ func PrintBlock(
 	}
 
 	sep()
-	row(fmt.Sprintf("NETWORK : %s", network))
+
+	printNetwork(network)
 
 	bottom()
 }
@@ -125,3 +126,26 @@ func trim(s string) string {
 	}
 	return s
 }
+
+func printNetwork(n string) {
+
+	if n == "" {
+		row("NETWORK : unavailable")
+		return
+	}
+
+	parts := strings.Fields(n)
+
+	if len(parts) < 6 {
+		row("NETWORK : " + trim(n))
+		return
+	}
+
+	iface := parts[0]
+	rx := parts[2]
+	tx := parts[4]
+	drops := parts[len(parts)-1]
+
+	row(fmt.Sprintf("NETWORK : %-5s RX: %-5s TX: %-5s", iface, rx, tx))
+	row(fmt.Sprintf("DROPS   : %s", drops))
+}