Diagnostics does not display on certain lines

[rishyramen]

I noticed that on certain lines some very basic diagnostics doesn't display through tiny's ui.

I'm not sure what the exact conditions are but I did notice when I add a space in the above example it did end up showing

-- nvim -u minimal.lua --noplugin
vim.lsp.enable('nixd')
vim.cmd.packadd('tiny-inline-diagnostic.nvim')
require('tiny-inline-diagnostic').setup {
  options = {
    show_diags_only_under_cursor = true,
    multilines = {
      -- enabled = true,
      -- always_show = true
    }
  },
  signs = {
    left = '',
    right = '',
  },
}

Here the attached lsp is nixd but I do notice it when using lua_ls as well.

[rachartier]

Are you sure the lsp is running ? Open a file, do not edit it, and check if the lsp is started

[rishyramen]

I believe so, it shows that it's attached in checkhealth. I'll attach a recording, please let me know if I'm doing anything wrong.

diagnostic-behavior.mov

[rachartier]

And with that config, does it works better?

require('tiny-inline-diagnostic').setup {
  options = {
      multilines = { enabled = true, always_show = false },
  },
  signs = {
    left = '',
    right = '',
  },
}

[rishyramen]

It does show when removing show_diags_only_under_cursor = true, but I'd love to keep that setting on if possible. Either way, I just wanted to flag it in case it's a bug or an obvious misconfiguration on my end so no rush but thank you for the quick responses.

[rachartier]

Can you please test this update with your config?

[rishyramen]

Looks resolved on my end, thanks man.

[rishyramen]

Mb, I think I made a mistake while testing the fix.
I believe the underlying cause is actually an off-by-one discrepancy.

As you can see above col == end_col == 33. However after adding a log statement to at_position I observed that the cursor column at the time the filter module runs is 32 (logged as 22:32 at the bottom).

I'm not sure whether this is expected behavior from this specific LSP or a bug but I speculate that either

1. the LSP is using 1-based column indexing, while Tiny is using 0-based indexing.
2. the diagnostic location is past the range of the cursor which is why I can't get it show

I'm going to switch to using show_all_diags_on_cursorline = true as I think I prefer that option so I don't need this fix anymore, but I will reopen the issue in case this needs attention.

[rachartier]

Thanks for reporting back, it should be fixed. I've taken into account zero-width range!