Fix #847: missing range checks in statespace_*.h files (#848)

Author: mhucka

lib/statespace_avx.h

@@ -399,7 +399,7 @@ class StateSpaceAVX :
           double re = p[16 * k + j];
           double im = p[16 * k + 8 + j];
           csum += re * re + im * im;
-          while (rs[m] < csum && m < num_samples) {
+          while (m < num_samples && rs[m] < csum) {
             bitstrings.emplace_back(8 * k + j);
             ++m;
           }

lib/statespace_avx512.h

@@ -350,7 +350,7 @@ class StateSpaceAVX512 :
           double re = p[32 * k + j];
           double im = p[32 * k + 16 + j];
           csum += re * re + im * im;
-          while (rs[m] < csum && m < num_samples) {
+          while (m < num_samples && rs[m] < csum) {
             bitstrings.emplace_back(16 * k + j);
             ++m;
           }

lib/statespace_basic.h

@@ -218,7 +218,7 @@ class StateSpaceBasic :
         double re = p[2 * k];
         double im = p[2 * k + 1];
         csum += re * re + im * im;
-        while (rs[m] < csum && m < num_samples) {
+        while (m < num_samples && rs[m] < csum) {
           bitstrings.emplace_back(k);
           ++m;
         }

lib/statespace_cuda_kernels.h

@@ -317,7 +317,7 @@ __global__ void SampleKernel(unsigned num_blocks,
         FP3 re = state[l];
         FP3 im = state[l + warp_size];
         csum += re * re + im * im;
-        while (rs[m] < csum && m < num_samples) {
+        while (m < num_samples && rs[m] < csum) {
           bitstrings[m++] = k0 + k;
         }
       }

lib/statespace_sse.h

@@ -359,7 +359,7 @@ class StateSpaceSSE :
           double re = p[8 * k + j];
           double im = p[8 * k + 4 + j];
           csum += re * re + im * im;
-          while (rs[m] < csum && m < num_samples) {
+          while (m < num_samples && rs[m] < csum) {
             bitstrings.emplace_back(4 * k + j);
             ++m;
           }