Fix conditional

Author: mhucka

.github/workflows/_find_changes.yaml

@@ -21,8 +21,8 @@
 # protection rules work is: "If a workflow is skipped due to path filtering
 # [...] the checks associated with that workflow will remain in a Pending
 # state. A PR that requires those checks to be successful will be blocked from
-# merging." This makes path filters unusable with merge queues. We forgo the
-# use of path filters, and instead check file changes using our own workflow.
+# merging." This makes path filters unusable with merge queues. So, we forgo the
+# use of path filters and instead check file changes using our own workflow.
 # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 # The tilde is only to make our reusable workflows be listed last in the UI.
@@ -31,6 +31,9 @@ run-name: Determine which files have been changed
 
 on:
   workflow_call:
+    # N.B.: GitHub Actions workflow_call output values are ALWAYS strings, even
+    # for (what you think are) Booleans. Consequently, calling workflows have to
+    # test values using, e.g., ${{foo = 'false'}}, and not ${{foo}} or similar.
     outputs:
       code:
         description: 'True if any potential code file was changed'

.github/workflows/ci_build_library.yaml

@@ -50,7 +50,9 @@ jobs:
 
   build-wheels:
     # For efficiency, skip this workflow if there were no code file changes.
-    if: needs.find-changes.outputs.code || github.event_name == 'workflow_dispatch'
+    if: >-
+      ${{needs.find-changes.outputs.code == 'true'
+         || github.event_name == 'workflow_dispatch'}}
     name: ${{matrix.conf.os}}/${{matrix.conf.pyarch}}/py3${{matrix.conf.py}}
     needs: find-changes
     runs-on: ${{matrix.conf.os}}

.github/workflows/ci_build_wheels.yaml

@@ -50,7 +50,9 @@ jobs:
 
   build-wheels:
     # For efficiency, skip this workflow if there were no code file changes.
-    if: needs.find-changes.outputs.code || github.event_name == 'workflow_dispatch'
+    if: >-
+      ${{needs.find-changes.outputs.code == 'true'
+         || github.event_name == 'workflow_dispatch'}}
     name: Build & test wheels
     needs: find-changes
     uses: ./.github/workflows/_build_wheels.yaml

.github/workflows/ci_docker_tests.yaml

@@ -50,7 +50,9 @@ jobs:
 
   build-and-test:
     # For efficiency, skip this workflow if there were no code file changes.
-    if: needs.find-changes.outputs.code || github.event_name == 'workflow_dispatch'
+    if: >-
+      ${{needs.find-changes.outputs.code == 'true'
+         || github.event_name == 'workflow_dispatch'}}
     name: Build and test Docker images
     needs: find-changes
     runs-on: ubuntu-24.04

.github/workflows/ci_format_checks.yml

@@ -57,6 +57,9 @@ jobs:
     needs: find-changes
     runs-on: ubuntu-24.04
     timeout-minutes: 30
+    env:
+      # Add xtrace to SHELLOPTS for all Bash scripts when doing debug runs.
+      SHELLOPTS: ${{inputs.debug && 'xtrace' || '' }}
     steps:
       - name: Check out a copy of the git repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
@@ -79,7 +82,4 @@ jobs:
           pip install -r dev-requirements.txt
 
       - name: Check Python file format
-        env:
-          # SHELLOPTS is used by Bash. Add xtrace when doing manual debug runs.
-          SHELLOPTS: ${{inputs.debug && 'xtrace' || '' }}
         run: check/format-incremental

.github/workflows/ci_hardware_options.yaml

@@ -49,8 +49,10 @@ jobs:
     secrets: inherit
 
   test-options:
-    # For efficiency, skip this workflow if there were no code file changes.
-    if: needs.find-changes.outputs.code || github.event_name == 'workflow_dispatch'
+    # For efficiency, skip this workflow if there were no Python file changes.
+    if: >-
+      ${{needs.find-changes.outputs.python == 'true'
+         || github.event_name == 'workflow_dispatch'}}
     name: Test ${{matrix.hardware_opt}} + ${{matrix.parallel_opt}}
     needs: find-changes
     runs-on: ubuntu-24.04

.github/workflows/ci_sanitizer_tests.yaml

@@ -49,8 +49,10 @@ jobs:
     secrets: inherit
 
   sanitizer-tests:
-    # For efficiency, skip this workflow if there were no code file changes.
-    if: needs.find-changes.outputs.code || github.event_name == 'workflow_dispatch'
+    # For efficiency, skip this workflow if there were no Python file changes.
+    if: >-
+      ${{needs.find-changes.outputs.python == 'true'
+         || github.event_name == 'workflow_dispatch'}}
     name: Test with sanitizers
     needs: find-changes
     runs-on: ubuntu-24.04

.github/workflows/ci_tcmalloc_test.yaml

@@ -50,7 +50,9 @@ jobs:
 
   tcmalloc-test:
     # For efficiency, skip this workflow if there were no code file changes.
-    if: needs.find-changes.outputs.code || github.event_name == 'workflow_dispatch'
+    if: >-
+      ${{needs.find-changes.outputs.code == 'true'
+         || github.event_name == 'workflow_dispatch'}}
     name: Test with TCMalloc
     needs: find-changes
     runs-on: ubuntu-24.04