Don't set /O2 unconditionally on Windows

When MSVC is being used and the build is a debug build, we get errors
involving /O2 and /RCT1.

Author: mhucka

pybind_interface/avx2/CMakeLists.txt

@@ -15,11 +15,14 @@
 cmake_minimum_required(VERSION 3.28)
 project(qsim)
 
-IF (WIN32)
-    add_compile_options(/arch:AVX2 /O2 /openmp)
-ELSE()
+if(WIN32)
+    add_compile_options(/arch:AVX2 /openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
+else()
     add_compile_options(-mavx2 -mfma -O3 -flto=auto)
-ENDIF()
+endif()
 
 if(APPLE)
     include_directories(
@@ -36,7 +39,7 @@ if(APPLE)
     )
 endif()
 
-INCLUDE(../GetPybind11.cmake)
+include(../GetPybind11.cmake)
 pybind11_add_module(qsim_avx2 pybind_main_avx2.cpp)
 
 target_link_libraries(qsim_avx2 PUBLIC OpenMP::OpenMP_CXX)

pybind_interface/avx512/CMakeLists.txt

@@ -15,11 +15,14 @@
 cmake_minimum_required(VERSION 3.28)
 project(qsim)
 
-IF (WIN32)
-    add_compile_options(/arch:AVX512 /O2 /openmp)
-ELSE()
+if(WIN32)
+    add_compile_options(/arch:AVX512 /openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
+else()
     add_compile_options(-mavx512f -mbmi2 -O3 -flto=auto)
-ENDIF()
+endif()
 
 if(APPLE)
     include_directories(
@@ -36,7 +39,7 @@ if(APPLE)
     )
 endif()
 
-INCLUDE(../GetPybind11.cmake)
+include(../GetPybind11.cmake)
 pybind11_add_module(qsim_avx512 pybind_main_avx512.cpp)
 
 target_link_libraries(qsim_avx512 PUBLIC OpenMP::OpenMP_CXX)

pybind_interface/basic/CMakeLists.txt

@@ -16,7 +16,10 @@ cmake_minimum_required(VERSION 3.28)
 project(qsim)
 
 if(WIN32)
-    add_compile_options(/O2 /openmp)
+    add_compile_options(/openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
 else()
     add_compile_options(-O3 -flto=auto)
 endif()
@@ -36,7 +39,7 @@ if(APPLE)
     )
 endif()
 
-INCLUDE(../GetPybind11.cmake)
+include(../GetPybind11.cmake)
 pybind11_add_module(qsim_basic pybind_main_basic.cpp)
 
 target_link_libraries(qsim_basic PUBLIC OpenMP::OpenMP_CXX)

pybind_interface/cuda/CMakeLists.txt

@@ -16,7 +16,12 @@ cmake_minimum_required(VERSION 3.28)
 project(qsim LANGUAGES CXX CUDA)
 
 if(WIN32)
-    add_compile_options(/O2 /openmp)
+    # Always apply AVX2 and openmp on Windows
+    add_compile_options(/openmp)
+
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
 else()
     add_compile_options(-O3 -flto=auto)
 endif()

pybind_interface/custatevec/CMakeLists.txt

@@ -16,7 +16,10 @@ cmake_minimum_required(VERSION 3.28)
 project(qsim LANGUAGES CXX CUDA)
 
 if(WIN32)
-    add_compile_options(/O2 /openmp)
+    add_compile_options(/openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
 else()
     add_compile_options(-O3 -flto=auto)
 endif()
@@ -36,7 +39,7 @@ if(APPLE)
     )
 endif()
 
-INCLUDE(../GetPybind11.cmake)
+include(../GetPybind11.cmake)
 find_package(Python3 3.10 REQUIRED)
 
 include_directories(${pybind11_INCLUDE_DIRS})

pybind_interface/decide/CMakeLists.txt

@@ -19,7 +19,10 @@ include(CheckLanguage)
 check_language(CUDA)
 
 if(WIN32)
-    add_compile_options(/O2 /openmp)
+    add_compile_options(/openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
 else()
     add_compile_options(-O3 -flto=auto)
 endif()

pybind_interface/hip/CMakeLists.txt

@@ -16,12 +16,15 @@ cmake_minimum_required(VERSION 3.28)
 project(qsim LANGUAGES CXX HIP)
 
 if(WIN32)
-    add_compile_options(/O2 /openmp)
+    add_compile_options(/openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
 else()
     add_compile_options(-O3 -flto=auto)
 endif()
 
-INCLUDE(../GetPybind11.cmake)
+include(../GetPybind11.cmake)
 find_package(PythonLibs 3.10 REQUIRED)
 
 list(APPEND CMAKE_MODULE_PATH "/opt/rocm/lib/cmake/hip")

pybind_interface/sse/CMakeLists.txt

@@ -15,11 +15,14 @@
 cmake_minimum_required(VERSION 3.28)
 project(qsim)
 
-IF (WIN32)
-    add_compile_options(/O2 /openmp)
-ELSE()
+if(WIN32)
+    add_compile_options(/openmp)
+    # Only apply /O2 if the configuration is RELEASE.
+    # This prevents a conflict with /RTC1 in DEBUG builds.
+    add_compile_options($<$<CONFIG:RELEASE>:/O2>
+else()
     add_compile_options(-msse4.1 -O3 -flto=auto)
-ENDIF()
+endif()
 
 if(APPLE)
     include_directories(
@@ -36,7 +39,7 @@ if(APPLE)
     )
 endif()
 
-INCLUDE(../GetPybind11.cmake)
+include(../GetPybind11.cmake)
 pybind11_add_module(qsim_sse pybind_main_sse.cpp)
 
 target_link_libraries(qsim_sse PUBLIC OpenMP::OpenMP_CXX)