ruff check lint fixes

Author: mpharrigan

dev_tools/qualtran_dev_tools/make_reference_docs/_components/render_docstring.py

@@ -167,7 +167,7 @@ def _write_yields(f, part: DocstringSectionYields, level: int):
         f.write('\n')
 
     else:
-        subpart: DocstringYield
+        param: DocstringYield
         for param in part.value:
             pname = param.name if param.name else 'yld'
             f.write(f'{pname}\n')

dev_tools/qualtran_dev_tools/make_reference_docs/_make.py

@@ -11,6 +11,8 @@
 #  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
+
+# ruff: noqa: E402
 import ast
 import warnings
 from collections import defaultdict

dev_tools/qualtran_dev_tools/shell_tools.py

@@ -91,7 +91,9 @@ def run(
         if abbreviate_non_option_arguments:
             cmd_desc = abbreviate_command_arguments_after_switches(cmd_desc)
         print("run:", cmd_desc, file=sys.stderr)
-    return subprocess.run(args, **subprocess_run_kwargs)  # pylint: disable=subprocess-run-check
+    return subprocess.run(  # noqa: PLW1510
+        args, **subprocess_run_kwargs
+    )  # pylint: disable=subprocess-run-check
 
 
 def output_of(args: Union[str, List[str]], **kwargs) -> str:

qualtran/bloqs/block_encoding/product_test.py

@@ -234,12 +234,12 @@ def test_product_symbolic_call_graph_decomposes():
     from qualtran.bloqs.basic_gates import Hadamard, TGate
     from qualtran.bloqs.block_encoding.unitary import Unitary
 
-    product_block_encoding = Product(
+    Product(
         (
             Unitary(TGate(), ancilla_bitsize=sympy.symbols("anc")),
             Unitary(Hadamard(), ancilla_bitsize=sympy.symbols("anc")),
         )
-    )
+    ).decompose_bloq()
 
 
 @pytest.mark.notebook

qualtran/bloqs/chemistry/trotter/hubbard/hubbard.ipynb

@@ -17,9 +17,9 @@
     "H = H_h + H_I\n",
     "$$\n",
     "\n",
-    "where the hopping hamiltonian is given as \n",
+    "where the hopping hamiltonian is given as\n",
     "$$\n",
-    "H_h = -\\tau \\sum_{\\langle p, q\\rangle, \\sigma} \n",
+    "H_h = -\\tau \\sum_{\\langle p, q\\rangle, \\sigma}\n",
     "    \\left(a_{p\\sigma}^{\\dagger} a_{q\\sigma} + \\mathrm{h.c.} \\right)\n",
     "$$\n",
     "where the sum is over nearest neighbour lattice sites (under periodic boundary conditions).\n",

qualtran/bloqs/chemistry/trotter/ising/ising.ipynb

@@ -9,7 +9,7 @@
    "source": [
     "# Ising Trotter Bloqs\n",
     "\n",
-    "Bloqs implementing Trotter steps for the 1D Ising model under periodic boundary conditions. \n",
+    "Bloqs implementing Trotter steps for the 1D Ising model under periodic boundary conditions.\n",
     "\n",
     "The Ising model is given as\n",
     "$$\n",

qualtran/bloqs/gf_arithmetic/gf2_multiplication.ipynb

@@ -224,7 +224,7 @@
     "from qualtran import QGF\n",
     "\n",
     "mx = galois.Poly.Degrees([0, 1, 3])  # x^3 + x + 1\n",
-    "gf = galois.GF(2, 3, irreducible_poly=mx)\n",
+    "# gf = galois.GF(2, 3, irreducible_poly=mx)\n",
     "const = 5  # x^2 + 1\n",
     "gf2_multiply_by_constant = GF2MulK(QGF(2, 3, mx), const)"
    ]

qualtran/bloqs/gf_arithmetic/gf2_multiplication.py

@@ -478,7 +478,7 @@ def _gf2_multiply_by_constant() -> GF2MulK:
     from qualtran import QGF
 
     mx = galois.Poly.Degrees([0, 1, 3])  # x^3 + x + 1
-    gf = galois.GF(2, 3, irreducible_poly=mx)
+    # gf = galois.GF(2, 3, irreducible_poly=mx)
     const = 5  # x^2 + 1
     gf2_multiply_by_constant = GF2MulK(QGF(2, 3, mx), const)
     return gf2_multiply_by_constant

qualtran/bloqs/rotations/phase_gradient.ipynb

@@ -227,7 +227,7 @@
    },
    "outputs": [],
    "source": [
-    "from qualtran import QFxp\n",
+    "from qualtran import QFxp  # noqa: F401\n",
     "\n",
     "phase_gradient_state = PhaseGradientState(4)"
    ]

qualtran/bloqs/rotations/phase_gradient.py

@@ -215,7 +215,7 @@ def decompose_from_registers(
 # pylint:  disable=unused-import
 @bloq_example
 def _phase_gradient_state() -> PhaseGradientState:
-    from qualtran import QFxp
+    from qualtran import QFxp  # noqa: F401
 
     phase_gradient_state = PhaseGradientState(4)
     return phase_gradient_state