Merge branch 'master' into mh-fix-1064

Author: mhucka

.github/workflows/scorecard.yaml

@@ -61,7 +61,7 @@ jobs:
           persist-credentials: false
 
       - name: Run Scorecard analysis
-        uses: ossf/scorecard-action@f49aabe0b5af0936a0987cfb85d86b75731b0186 # v2.4.1
+        uses: ossf/scorecard-action@05b42c624433fc40578a4040d5cf5e36ddca8cde # v2.4.2
         with:
           # Save the results
           results_file: scorecard-results.sarif

src/openfermion/conftest.py

@@ -9,9 +9,20 @@
 #   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
+
 import os
+import random
+import pytest
+import numpy as np
 
 
 def pytest_configure(config):
     # fail tests when using deprecated cirq functionality
     os.environ['CIRQ_TESTING'] = "true"
+
+
+@pytest.fixture(autouse=True)
+def set_random_seed():
+    """Set a fixed random seed when testing."""
+    random.seed(0)
+    np.random.seed(0)

src/openfermion/resource_estimates/pbc/hamiltonian/cc_extensions.py

@@ -69,7 +69,6 @@ def build_approximate_eris(krcc_inst, eri_helper, eris=None):
         eri_kpt = eri_helper.get_eri(kpts) / nkpts
         if dtype == float:
             eri_kpt = eri_kpt.real
-        eri_kpt = eri_kpt
         for kp, kq, kr in khelper.symm_map[(ikp, ikq, ikr)]:
             eri_kpt_symm = khelper.transform_symm(eri_kpt, kp, kq, kr).transpose(0, 2, 1, 3)
             out_eris.oooo[kp, kr, kq] = eri_kpt_symm[:nocc, :nocc, :nocc, :nocc]

src/openfermion/resource_estimates/pbc/thc/factorizations/isdf.py

@@ -575,18 +575,14 @@ def kpoint_isdf_double_translation(
     num_kpts = len(kpts)
     num_interp_points = xi.shape[1]
     assert xi.shape == (num_grid_points, num_interp_points)
-    (
-        g_vectors,
-        g_mapping,
-        g_mapping_unique,
-        delta_gs_unique,
-    ) = build_g_vector_mappings_double_translation(df_inst.cell, kpts, momentum_map)
+    (g_vectors, g_mapping, g_mapping_unique, delta_gs_unique) = (
+        build_g_vector_mappings_double_translation(df_inst.cell, kpts, momentum_map)
+    )
     if only_unique_g:
         g_mapping = g_mapping_unique
         delta_gs = delta_gs_unique
     else:
         delta_gs = [g_vectors] * num_kpts
-        g_mapping = g_mapping
     zeta = np.zeros((num_kpts,), dtype=object)
     for iq in range(num_kpts):
         num_g = len(delta_gs[iq])
@@ -914,7 +910,6 @@ def solve_kmeans_kpisdf(
         weighting_function = np.einsum(
             "kRi,kRi->R", bloch_orbitals_mo.conj(), bloch_orbitals_mo, optimize=True
         )
-        weighting_function = weighting_function
     else:
         raise ValueError(f"Unknown value for weighting function {kmeans_weighting_function}")
     interp_indx = kmeans.find_interpolating_points(