Skip to content

Commit 2fca896

Browse files
committed
Rename nightly pytest workflow
Changes: * Use a leading underscore in the file name, because that seems to be more conventional in other repos using sub-workflows. * Rename the run-name of the workflow itself to be more accurate and informational.
1 parent 2c36484 commit 2fca896

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717
# This workflow expects input values passed by nightly.yml.
1818
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1919

20-
name: 'Nightly tests & scans – Pytest matrix'
21-
run-name: Run nightly Pytest
20+
# The tilde is only to make our sub-workflows be listed last in the GitHub UI.
21+
name: '~ Cirq version tests'
22+
run-name: >-
23+
Run tests using the ${{inputs.cirq-release}} version of Cirq ${{inputs.reason}}
2224
2325
on:
2426
workflow_call:
@@ -27,10 +29,14 @@ on:
2729
args:
2830
type: string
2931
required: false
30-
# Why is this workflow being called?
32+
# (For the job name) Why is this workflow being called?
3133
reason:
3234
type: string
3335
required: false
36+
# (For the job name) What version of Cirq will be used?
37+
cirq-release:
38+
type: string
39+
required: false
3440

3541
# Allow manual invocation.
3642
workflow_dispatch:

.github/workflows/nightly.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,19 @@ permissions: read-all
3636
jobs:
3737
cirq-stable:
3838
name: Nightly Pytest Cirq stable
39-
uses: ./.github/workflows/nightly-pytest.yaml
39+
uses: ./.github/workflows/_nightly-cirq-test.yaml
4040
with:
4141
args: ''
4242
reason: '(nightly)'
43+
cirq-release: 'stable'
4344

4445
cirq-pre:
4546
name: Nightly Pytest Cirq pre-release
46-
uses: ./.github/workflows/nightly-pytest.yaml
47+
uses: ./.github/workflows/_nightly-cirq-test.yaml
4748
with:
4849
args: '--pre'
4950
reason: '(nightly)'
51+
cirq-release: 'pre-release'
5052

5153
codeql:
5254
name: Nightly CodeQL code scan

0 commit comments

Comments
 (0)