replace all hardcoded status code by their constant

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

Author: Nexucis

rest/api.go

@@ -130,13 +130,13 @@ func (a *API) diagnostics(w http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	requestID, requestData, err := getRequestDataAndID(ctx)
 	if err != nil {
-		http.Error(w, err.Error(), 500)
+		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
 
 	diagnostics, err := a.langServer.GetDiagnostics(requestID)
 	if err != nil {
-		http.Error(w, errors.Wrapf(err, "failed to get diagnostics").Error(), 500)
+		http.Error(w, errors.Wrapf(err, "failed to get diagnostics").Error(), http.StatusInternalServerError)
 		return
 	}
 
@@ -153,12 +153,12 @@ func (a *API) hover(w http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	requestID, requestData, err := getRequestDataAndID(ctx)
 	if err != nil {
-		http.Error(w, err.Error(), 500)
+		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
 	position, err := requestData.returnPosition()
 	if err != nil {
-		http.Error(w, err.Error(), 400)
+		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}
 
@@ -171,7 +171,7 @@ func (a *API) hover(w http.ResponseWriter, r *http.Request) {
 		},
 	})
 	if err != nil {
-		http.Error(w, errors.Wrapf(err, "failed to get hover info").Error(), 500)
+		http.Error(w, errors.Wrapf(err, "failed to get hover info").Error(), http.StatusInternalServerError)
 		return
 	}
 
@@ -182,12 +182,12 @@ func (a *API) completion(w http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	requestID, requestData, err := getRequestDataAndID(ctx)
 	if err != nil {
-		http.Error(w, err.Error(), 500)
+		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
 	position, err := requestData.returnPosition()
 	if err != nil {
-		http.Error(w, err.Error(), 400)
+		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}
 
@@ -217,12 +217,12 @@ func (a *API) signature(w http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	requestID, requestData, err := getRequestDataAndID(ctx)
 	if err != nil {
-		http.Error(w, err.Error(), 500)
+		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
 	position, err := requestData.returnPosition()
 	if err != nil {
-		http.Error(w, err.Error(), 400)
+		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}
 

rest/middleware.go

@@ -84,7 +84,7 @@ func manageDocumentMiddleware(langServer langserver.HeadlessServer) middlewareFu
 			// start to generate an unique ID for the given request
 			id, err := uuid.NewRandom()
 			if err != nil {
-				http.Error(w, err.Error(), 500)
+				http.Error(w, err.Error(), http.StatusInternalServerError)
 				return
 			}
 			requestID := protocol.DocumentURI(id.String())
@@ -96,10 +96,10 @@ func manageDocumentMiddleware(langServer langserver.HeadlessServer) middlewareFu
 			if err := json.NewDecoder(r.Body).Decode(data); err != nil {
 				if err == io.EOF {
 					// this case is used just in order to have a proper error message instead of just "EOF"
-					http.Error(w, fmt.Sprint("body not present"), 400)
+					http.Error(w, fmt.Sprint("body not present"), http.StatusBadRequest)
 					return
 				}
-				http.Error(w, err.Error(), 400)
+				http.Error(w, err.Error(), http.StatusBadRequest)
 				return
 			}
 			// inject the data unmarshalled to avoid to have to decode it later