fix: simplify CLI --protected flag to accept optional duration

- Change --protected from bool to string flag accepting duration
- Remove separate --protection-duration flag
- Usage: --protected (default duration), --protected=1440 (1 day),
  --protected=0 (forever), --protected=false (disable)
- Fix lint error by using constant for default warning minutes

Author: claude

engine/cmd/cli/commands/clone/actions.go

@@ -12,6 +12,7 @@ import (
 	"net/url"
 	"os"
 	"path"
+	"strconv"
 	"strings"
 	"sync"
 
@@ -25,6 +26,33 @@ import (
 	"gitlab.com/postgres-ai/database-lab/v3/pkg/models"
 )
 
+// parseProtectionFlag parses the --protected flag value.
+// Returns (isProtected, durationMinutes, error).
+// durationMinutes is nil if default duration should be used.
+func parseProtectionFlag(cliCtx *cli.Context) (bool, *uint, error) {
+	if !cliCtx.IsSet("protected") {
+		return false, nil, nil
+	}
+
+	value := cliCtx.String("protected")
+
+	switch strings.ToLower(value) {
+	case "", "true":
+		return true, nil, nil
+	case "false":
+		return false, nil, nil
+	default:
+		duration, err := strconv.ParseUint(value, 10, 64)
+		if err != nil {
+			return false, nil, errors.Errorf("invalid protection duration: %s (expected number of minutes or 'true'/'false')", value)
+		}
+
+		d := uint(duration)
+
+		return true, &d, nil
+	}
+}
+
 // list runs a request to list clones of an instance.
 func list(cliCtx *cli.Context) error {
 	dblabClient, err := commands.ClientByCLIContext(cliCtx)
@@ -96,9 +124,15 @@ func create(cliCtx *cli.Context) error {
 		return err
 	}
 
+	isProtected, protectionDuration, err := parseProtectionFlag(cliCtx)
+	if err != nil {
+		return err
+	}
+
 	cloneRequest := types.CloneCreateRequest{
-		ID:        cliCtx.String("id"),
-		Protected: cliCtx.Bool("protected"),
+		ID:                        cliCtx.String("id"),
+		Protected:                 isProtected,
+		ProtectionDurationMinutes: protectionDuration,
 		DB: &types.DatabaseRequest{
 			Username:   cliCtx.String("username"),
 			Password:   cliCtx.String("password"),
@@ -108,11 +142,6 @@ func create(cliCtx *cli.Context) error {
 		Branch: cliCtx.String("branch"),
 	}
 
-	if cliCtx.IsSet("protection-duration") {
-		duration := cliCtx.Uint("protection-duration")
-		cloneRequest.ProtectionDurationMinutes = &duration
-	}
-
 	if cliCtx.IsSet("snapshot-id") {
 		cloneRequest.Snapshot = &types.SnapshotCloneFieldRequest{ID: cliCtx.String("snapshot-id")}
 	}
@@ -189,13 +218,14 @@ func update(cliCtx *cli.Context) error {
 		return err
 	}
 
-	updateRequest := types.CloneUpdateRequest{
-		Protected: cliCtx.Bool("protected"),
+	isProtected, protectionDuration, err := parseProtectionFlag(cliCtx)
+	if err != nil {
+		return err
 	}
 
-	if cliCtx.IsSet("protection-duration") {
-		duration := cliCtx.Uint("protection-duration")
-		updateRequest.ProtectionDurationMinutes = &duration
+	updateRequest := types.CloneUpdateRequest{
+		Protected:                 isProtected,
+		ProtectionDurationMinutes: protectionDuration,
 	}
 
 	cloneID := cliCtx.Args().First()

engine/cmd/cli/commands/clone/command_list.go

@@ -68,15 +68,11 @@ func CommandList() []*cli.Command {
 						Name:  "branch",
 						Usage: "branch name (optional)",
 					},
-					&cli.BoolFlag{
+					&cli.StringFlag{
 						Name:    "protected",
-						Usage:   "mark instance as protected from deletion",
+						Usage:   "enable deletion protection; optionally specify duration in minutes (e.g., --protected=1440 for 1 day, 0 for forever)",
 						Aliases: []string{"p"},
 					},
-					&cli.UintFlag{
-						Name:  "protection-duration",
-						Usage: "protection duration in minutes (0 = forever, requires --protected)",
-					},
 					&cli.BoolFlag{
 						Name:    "async",
 						Usage:   "run the command asynchronously",
@@ -95,15 +91,11 @@ func CommandList() []*cli.Command {
 				Before:    checkCloneIDBefore,
 				Action:    update,
 				Flags: []cli.Flag{
-					&cli.BoolFlag{
+					&cli.StringFlag{
 						Name:    "protected",
-						Usage:   "mark instance as protected from deletion",
+						Usage:   "enable deletion protection; optionally specify duration in minutes (e.g., --protected=1440 for 1 day, 0 for forever, false to disable)",
 						Aliases: []string{"p"},
 					},
-					&cli.UintFlag{
-						Name:  "protection-duration",
-						Usage: "protection duration in minutes (0 = forever)",
-					},
 				},
 			},
 			{

engine/internal/cloning/base.go

@@ -34,7 +34,8 @@ import (
 )
 
 const (
-	idleCheckDuration = 5 * time.Minute
+	idleCheckDuration            = 5 * time.Minute
+	defaultWarningMinutes   uint = 24 * 60 // 24 hours
 )
 
 // Config contains a cloning configuration.
@@ -920,7 +921,7 @@ func (c *Base) runProtectionLeaseCheck(ctx context.Context) {
 func (c *Base) checkProtectionLeases(ctx context.Context) {
 	warningMinutes := c.config.ProtectionExpiryWarningMinutes
 	if warningMinutes == 0 {
-		warningMinutes = 24 * 60
+		warningMinutes = defaultWarningMinutes
 	}
 
 	warningDuration := time.Duration(warningMinutes) * time.Minute