Commit 6f2f523
committed
fix(EffectComposer): drop dedupeByLastOccurrence, fixed upstream in r3f 9.7.0
r3f 9.7.0 fixes the reconciler bug this workaround existed for: internal
instance children were drifting out of sync on a keyed reorder (reported
upstream by us, fixed in pmndrs/react-three-fiber#3808). With the fix in
place, group.current.__r3f.children no longer contains a stale duplicate
after React moves a keyed child, so the dedupe step is no longer needed.
Bumped @react-three/fiber to ^9.7.0 and removed dedupeByLastOccurrence,
reading groupInstance.children directly.
Verified empirically: the existing reorder-with-key test passes on 9.7.0
without the workaround, and fails with the exact same symptom as before
(Expected EffectPass with 2 effects) when temporarily downgraded back to
9.6.1 with the workaround still removed - confirming this is the actual
upstream fix taking effect, not a coincidence.1 parent 76b09e5 commit 6f2f523
3 files changed
Lines changed: 196 additions & 42 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | 62 | | |
79 | 63 | | |
80 | 64 | | |
| |||
192 | 176 | | |
193 | 177 | | |
194 | 178 | | |
195 | | - | |
| 179 | + | |
196 | 180 | | |
197 | 181 | | |
198 | 182 | | |
| |||
0 commit comments