Skip to content

Commit b218894

Browse files
committed
fix
1 parent 2a2fbbf commit b218894

5 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- script: |
2929
cd e2e/composer-version
3030
composer install
31-
OUTPUT=$(../bashunit -a exit_code "1" "vendor/bin/phpstan --error-format=raw)
31+
OUTPUT=$(../bashunit -a exit_code "1" "vendor/bin/phpstan --error-format=raw")
3232
echo "$OUTPUT"
3333
../bashunit -a contains 'test.php:12:Version requirement will always evaluate to false.' "$OUTPUT"
3434
../bashunit -a contains 'test.php:32:Version requirement will always evaluate to false.' "$OUTPUT"

src/Rules/PHPUnit/AttributeVersionRequirementHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use function is_numeric;
1616
use function preg_match;
1717
use function sprintf;
18+
use function strpos;
1819
use function substr_count;
1920
use function version_compare;
2021

@@ -162,6 +163,7 @@ public function checkVersionRequirement(array $attributes, Scope $scope): array
162163
*/
163164
private function getAnalyzedPhpVersions(): array
164165
{
166+
// @phpstan-ignore phpstanApi.method
165167
[$minVersion, $maxVersion] = $this->phpVersionRangeHelper->getVersionRange();
166168
if ($minVersion !== null && $maxVersion !== null) {
167169
$versions = [];

tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ protected function getRule(): Rule
5050
),
5151
new AttributeVersionRequirementHelper(
5252
$phpunitVersion,
53-
self::getContainer()->getByType(ConfiguredPhpVersionRangeHelper::class),
53+
self::getContainer()->getByType(ConfiguredPhpVersionRangeHelper::class), // @phpstan-ignore phpstanApi.classConstant
5454
false,
5555
true,
5656
),

tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ protected function getRule(): Rule
194194
),
195195
new AttributeVersionRequirementHelper(
196196
$phpunitVersion,
197-
self::getContainer()->getByType(ConfiguredPhpVersionRangeHelper::class),
197+
self::getContainer()->getByType(ConfiguredPhpVersionRangeHelper::class), // @phpstan-ignore phpstanApi.classConstant
198198
$this->deprecationRulesInstalled,
199199
true,
200200
$this->warnAboutIncompleteVersion,

tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ protected function getRule(): Rule
5757
return new ClassAttributeRequiresPhpVersionRule(
5858
new AttributeVersionRequirementHelper(
5959
$phpunitVersion,
60-
self::getContainer()->getByType(ConfiguredPhpVersionRangeHelper::class),
60+
self::getContainer()->getByType(ConfiguredPhpVersionRangeHelper::class), // @phpstan-ignore phpstanApi.classConstant
6161
false,
6262
true,
6363
$this->warnAboutIncompleteVersion,

0 commit comments

Comments
 (0)