Skip to content

Commit 011ea59

Browse files
committed
more precise "is incomplete message"
1 parent 78ecac8 commit 011ea59

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/Rules/PHPUnit/AttributeVersionRequirementHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function checkVersionRequirement(array $attributes, Scope $scope): array
7878

7979
if ($this->warnAboutIncompleteVersion($versionRequirement)) {
8080
$errors[] = RuleErrorBuilder::message(
81-
sprintf('Version requirement %s is incomplete.', $versionRequirement),
81+
sprintf('Version requirement %s is incomplete. Expect a version composed of major, minor and patch.', $versionRequirement),
8282
)
8383
->identifier('phpunit.attributeRequiresPhpVersion')
8484
->build();

tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,11 @@ public function testWarnAboutIncompleteVersion(): void
158158

159159
$this->analyse([__DIR__ . '/data/requires-php-version.php'], [
160160
[
161-
'Version requirement 8.0 is incomplete.',
161+
'Version requirement 8.0 is incomplete. Expect a version composed of major, minor and patch.',
162162
12,
163163
],
164164
[
165-
'Version requirement >=8.0 is incomplete.',
165+
'Version requirement >=8.0 is incomplete. Expect a version composed of major, minor and patch.',
166166
20,
167167
],
168168
]);
@@ -177,7 +177,7 @@ public function testWarnAboutIncompletePhpunitVersion(): void
177177

178178
$this->analyse([__DIR__ . '/data/requires-phpunit-version.php'], [
179179
[
180-
'Version requirement 11.0 is incomplete.',
180+
'Version requirement 11.0 is incomplete. Expect a version composed of major, minor and patch.',
181181
12,
182182
],
183183
]);

tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function testWarnAboutIncompleteVersion(): void
3030
10,
3131
],
3232
[
33-
'Version requirement < 7.0 is incomplete.',
33+
'Version requirement < 7.0 is incomplete. Expect a version composed of major, minor and patch.',
3434
10,
3535
],
3636
]);
@@ -44,7 +44,7 @@ public function testWarnAboutIncompletePhpunitVersion(): void
4444

4545
$this->analyse([__DIR__ . '/data/requires-phpunit-version.php'], [
4646
[
47-
'Version requirement >=11.0 is incomplete.',
47+
'Version requirement >=11.0 is incomplete. Expect a version composed of major, minor and patch.',
4848
18,
4949
],
5050
]);

0 commit comments

Comments
 (0)