Deprecate a single parameter

[shyim]

Hey,

Google Cloud Storage has deprecated a single parameter: https://github.com/googleapis/google-cloud-php-storage/blob/4b81b682f6b1517c0c5f6152b2980195d23c1cef/src/StorageClient.php#L100

Now the entire constructor is marked as deprecated for this extension. Anything we could do here properly instead of ignoring at all?

[ondrejmirtes]

This is a question more for phpdoc-parser rather than here.

[jeromegamez]

Ha, I arrived here because of the exact same problem. I'm not sure it's in scope of the phpdoc-parser - on one hand, https://docs.phpdoc.org/guide/references/phpdoc/tags/deprecated.html says that @deprecated is associate with a structural element, not a parameters.

On the other hand, the StorageClient (and several others) don't deprecate the parameter, but just a field in the parameter: https://github.com/googleapis/google-cloud-php/blob/adcce2ce2b5d2e10f03335dbcc31d886d9af21b8/Storage/src/StorageClient.php#L83-L101

Abbreviated:

class StorageClient
{
	/**
     * @param array $config [optional] {
     *     Configuration options.
     *
     *     @type array $keyFile [DEPRECATED]
     *           @deprecated This option is being deprecated because of a potential security risk.
     * }
     */
	public function __construct(array $config = []) {}
}

I think the actual solution is to remove it in the Google Cloud Library, I created a PR to do this in googleapis/google-cloud-php#8689

Hope this helps!