Add more tests for some use cases

Author: jaapio

packages/guides-pages/src/Pages/DependencyInjection/PagesExtension.php

@@ -22,13 +22,9 @@
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 
 use function array_is_list;
-use function array_keys;
-use function array_map;
-use function array_values;
 use function dirname;
 use function is_array;
 use function ltrim;
-use function phpDocumentor\Guides\DependencyInjection\templateArray;
 
 /**
  * Symfony DI extension for the guides-pages package.
@@ -119,7 +115,6 @@ public function prepend(ContainerBuilder $container): void
         }
 
         $container->prependExtensionConfig('guides', [
-           // 'templates' => templateArray(require dirname(__DIR__, 3) . '/resources/template/page/template.php'),
             'base_template_paths' => [
                 dirname(__DIR__, 3) . '/resources/template/page',
             ],

packages/guides-pages/src/Pages/Nodes/ContentTypeItemNode.php

@@ -308,6 +308,7 @@ public function getSummary(): ParagraphNode|null
     {
         return $this->summary;
     }
+
     /**
      * Parses a raw date string (expected format `Y-m-d`) into a
      * {@see DateTimeImmutable}, returning `null` for empty or non-conforming

packages/guides-pages/tests/unit/Pages/DependencyInjection/PagesExtensionTest.php

@@ -16,38 +16,11 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
-use function array_filter;
 use function str_contains;
 
 /** @covers \phpDocumentor\Guides\Pages\DependencyInjection\PagesExtension */
 final class PagesExtensionTest extends TestCase
 {
-    public function testPrependRegistersPageTemplatesUnderGuidesExtension(): void
-    {
-        $container = new ContainerBuilder();
-        $extension = new PagesExtension();
-
-        $extension->prepend($container);
-
-        $configs = $container->getExtensionConfig('guides');
-        self::assertNotEmpty($configs, 'Expected at least one prepended guides config block');
-
-        // Collect all prepended templates across every config block
-        $allTemplates = [];
-        foreach ($configs as $block) {
-            foreach ($block['templates'] ?? [] as $tpl) {
-                $allTemplates[] = $tpl;
-            }
-        }
-
-        $pageTemplates = array_filter(
-            $allTemplates,
-            static fn (array $t): bool => ($t['format'] ?? '') === 'page',
-        );
-
-        self::assertNotEmpty($pageTemplates, 'PagesExtension should register at least one "page" format template');
-    }
-
     public function testPrependRegistersBaseTemplatePath(): void
     {
         $container = new ContainerBuilder();

tests/Integration/tests/pages/page-with-admonitions/expected/admonitions.html

@@ -0,0 +1,14 @@
+<!-- content start -->
+    <div class="section" id="admonitions">
+            <h1>Admonitions</h1>
+<div class="admonition note">
+    <p>This is a note.</p>
+</div>
+<div class="admonition warning">
+    <p>This is a warning.</p>
+</div>
+<div class="admonition tip">
+    <p>This is a tip.</p>
+</div>
+    </div>
+<!-- content end -->

tests/Integration/tests/pages/page-with-admonitions/input/guides.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<guides xmlns="https://www.phpdoc.org/guides"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="https://www.phpdoc.org/guides packages/guides-cli/resources/schema/guides.xsd"
+>
+    <extension class="phpDocumentor\Guides\Pages\DependencyInjection\PagesExtension"
+               source-directory="pages"
+    />
+</guides>

tests/Integration/tests/pages/page-with-admonitions/input/index.rst

@@ -0,0 +1,2 @@
+Index
+=====

tests/Integration/tests/pages/page-with-admonitions/input/pages/admonitions.rst

@@ -0,0 +1,15 @@
+===========
+Admonitions
+===========
+
+.. note::
+
+   This is a note.
+
+.. warning::
+
+   This is a warning.
+
+.. tip::
+
+   This is a tip.

tests/Integration/tests/pages/page-with-image/expected/hero.svg

@@ -0,0 +1,9 @@
+<!-- content start -->
+    <div class="section" id="image">
+            <h1>Image</h1>
+            <img
+    src="/hero.svg"
+    width="200"            alt="Hero illustration"        />
+
+    </div>
+<!-- content end -->

tests/Integration/tests/pages/page-with-image/expected/image.html

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<guides xmlns="https://www.phpdoc.org/guides"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="https://www.phpdoc.org/guides packages/guides-cli/resources/schema/guides.xsd"
+>
+    <extension class="phpDocumentor\Guides\Pages\DependencyInjection\PagesExtension"
+               source-directory="pages"
+    />
+</guides>