From 0bc1f616d0cd67398d3ee58d0c11f52a2f1ee19f Mon Sep 17 00:00:00 2001 From: Rohit Bhati Date: Thu, 27 Mar 2025 14:17:09 +0530 Subject: [PATCH 1/2] Ensure IDENTITY columns use defaults when no value is provided. #8483 --- .../schemas/tables/templates/columns/sql/default/nodes.sql | 1 + 1 file changed, 1 insertion(+) diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql index 9d53ed10c1b..adb23207558 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql @@ -1,6 +1,7 @@ SELECT DISTINCT att.attname as name, att.attnum as OID, pg_catalog.format_type(ty.oid,NULL) AS datatype, att.attnotnull as not_null, CASE WHEN att.atthasdef OR att.attidentity != '' THEN True +WHEN ty.typdefault IS NOT NULL THEN True ELSE False END as has_default_val, des.description, seq.seqtypid FROM pg_catalog.pg_attribute att JOIN pg_catalog.pg_type ty ON ty.oid=atttypid From 2597cd4b97226a844693c33784ac1db1d03ece66 Mon Sep 17 00:00:00 2001 From: Rohit Bhati Date: Thu, 27 Mar 2025 19:36:09 +0530 Subject: [PATCH 2/2] Update sql to use defaults. --- .../schemas/tables/templates/columns/sql/default/nodes.sql | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql index adb23207558..5bce8716a49 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/default/nodes.sql @@ -1,7 +1,6 @@ SELECT DISTINCT att.attname as name, att.attnum as OID, pg_catalog.format_type(ty.oid,NULL) AS datatype, att.attnotnull as not_null, -CASE WHEN att.atthasdef OR att.attidentity != '' THEN True -WHEN ty.typdefault IS NOT NULL THEN True +CASE WHEN att.atthasdef OR att.attidentity != '' OR ty.typdefault IS NOT NULL THEN True ELSE False END as has_default_val, des.description, seq.seqtypid FROM pg_catalog.pg_attribute att JOIN pg_catalog.pg_type ty ON ty.oid=atttypid