🪳Dont reference getter in method initialization (#187)

Author: JustinGrote

Scripts/PesterInterface.Tests.ps1

@@ -16,7 +16,7 @@ Describe 'PesterInterface' {
     It 'Basic.Tests Discovery' {
       $paths = "$testDataPath/Tests/Basic.Tests.ps1"
       & $PesterInterface -Path $paths -Discovery -PipeName $PipeOutPath -DryRun 6>$null
-      Get-Content $PipeOutPath | ConvertFrom-Json | ForEach-Object label | Should -HaveCount 61
+      Get-Content $PipeOutPath | ConvertFrom-Json | ForEach-Object label | Should -HaveCount 58
     }
 		It 'Simple Test Run' {
 			$paths = "$testDataPath/Tests/True.Tests.ps1"

package.json

@@ -58,7 +58,12 @@
 				},
 				"pester.configurationPath": {
 					"type": "string",
-					"markdownDescription": "Specifies the path to a custom Pester configuration in `.psd1` format. This is useful if you want to use a custom configuration file, or if you want to use a configuration file that is not named `PesterConfiguration.psd1`. If this is not set then the runner will look for a file named `PesterConfiguration.psd1` at the root of the workspace folder. This is best specified as a workspace setting and not a user setting. You may also provide a configuration via a `$PesterPreference` variable in your running session, this will apply for debug runs only."
+					"markdownDescription": "Specifies the path to a custom Pester configuration in `.psd1` format. This is useful if you want to use a custom configuration file, or if you want to use a configuration file that is not named `PesterConfiguration.psd1`. If this is not set then the runner will look for a file named `PesterConfiguration.psd1` at the root of the workspace folder. This is best specified as a workspace setting and not a user setting. You may also provide a configuration via a `$PesterPrefer ence` variable in your running session, this will apply for debug runs only."
+				},
+				"pester.testChangeTimeout": {
+					"type": "integer",
+					"default": 100,
+					"markdownDescription": "Specifies the timeout in milliseconds that the test adapter waits for changes to be detected before running the test. You may need to increase this value if you are on a slower computer and are getting duplicate runs after making changes or starting up the test adapter."
 				}
 			}
 		}

src/pesterTestController.ts

@@ -391,7 +391,17 @@ export class PesterTestController implements Disposable {
 
 		if (testItem !== undefined) {
 			const newTestItemData = testDef
-			const existingTestItemData = TestData.get(testItem)
+			const existingTestItemData = TestData.get(testItem) as TestDefinition
+
+			if (existingTestItemData === undefined) {
+				this.log.fatal(
+					`Test Item ${testDef.label} exists but does not have test data. This is a bug and should not happen`
+				)
+				throw new Error(
+					`Test Item ${testDef.label} exists but does not have test data. This is a bug and should not happen`
+				)
+			}
+
 			if (isDeepStrictEqual(existingTestItemData, newTestItemData)) {
 				this.log.trace(`Discovery: Test Exists but has not changed. Skipping: ${testDef.id}`)
 				return
@@ -476,7 +486,7 @@ export class PesterTestController implements Disposable {
 		}
 		this.discoveryQueue.clear()
 		return result
-	}, 300)
+	}, workspace.getConfiguration('pester', this.workspaceFolder).get<number>('testChangeTimeout') ?? 100)
 
 	/** The test controller API calls this when tests are requested to run in the UI. It handles both runs and debugging.
 	 * @param cancelToken The cancellation token passed by VSCode
@@ -736,7 +746,7 @@ export class PesterTestController implements Disposable {
 			scriptArgs.push(pesterCustomModulePath)
 		}
 
-		const configurationPath = workspace.getConfiguration('pester', this.workspaceFolder).get<string>('configurationPath')
+		const configurationPath = this.config.get<string>('configurationPath')
 		if (configurationPath !== undefined && configurationPath !== '') {
 			scriptArgs.push('-ConfigurationPath')
 			scriptArgs.push(configurationPath)