Just noticed this really bad message on project access when the role comes from the silo.
|
{ |
|
label: 'Change role', |
|
onActivate: () => setEditingUserRow(row), |
|
disabled: |
|
!row.projectRole && "You don't have permission to change this user's role", |
|
}, |
It's wrong in multiple ways:
- The current user may well be a silo admin who does in fact have permission to change that role
- Adding a project role is possible even if the user is only a project admin and not a silo admin
The reason it's disabled is because conceptually, in order to modify that actor's role on the project, you have to add a new role assignment on the project, not modify the existing one on the silo. We could do a lot better in this UI to make that clear.
Just noticed this really bad message on project access when the role comes from the silo.
console/app/pages/project/access/ProjectAccessPage.tsx
Lines 165 to 170 in ab76183
It's wrong in multiple ways:
The reason it's disabled is because conceptually, in order to modify that actor's role on the project, you have to add a new role assignment on the project, not modify the existing one on the silo. We could do a lot better in this UI to make that clear.