Merge pull request #75 from oslokommune/re-enable-low-level-retries

Re-enable retries on low-level errors

Author: simenheg

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 * Added support for the new [permission API](https://github.com/oslokommune/okdata-permission-api).
 
+* Retries have been re-enabled for low-level network errors (connection errors,
+  read errors, and redirects). The `retry` parameter now only controls the
+  maximum number of retries to perform on bad HTTP status codes.
+
 ## 0.7.0
 
 * `Dataset.update_dataset` now supports partial metadata updates when the

okdata/sdk/sdk.py

@@ -60,7 +60,7 @@ def delete(self, url, retries=0, **kwargs):
     def prepared_request_with_retries(retries):
         #  https://findwork.dev/blog/advanced-usage-python-requests-timeouts-retries-hooks/#retry-on-failure
         retry_strategy = Retry(
-            total=retries,
+            status=retries,
             status_forcelist=[429, 500, 502, 503, 504],
             backoff_factor=1,
             method_whitelist=[