diff --git a/openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/DataProductResourceIT.java b/openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/DataProductResourceIT.java index 2620ce2b8243..3627252de7c1 100644 --- a/openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/DataProductResourceIT.java +++ b/openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/DataProductResourceIT.java @@ -60,10 +60,12 @@ import org.openmetadata.schema.utils.JsonUtils; import org.openmetadata.schema.utils.ResultList; import org.openmetadata.sdk.client.OpenMetadataClient; +import org.openmetadata.sdk.exceptions.ForbiddenException; import org.openmetadata.sdk.exceptions.InvalidRequestException; import org.openmetadata.sdk.models.ListParams; import org.openmetadata.sdk.models.ListResponse; import org.openmetadata.sdk.network.HttpMethod; +import org.openmetadata.sdk.network.RequestOptions; /** * Integration tests for DataProduct entity operations. @@ -216,6 +218,110 @@ protected DataProduct getVersion(UUID id, Double version) { // DATA PRODUCT-SPECIFIC TESTS // =================================================================== + @Test + void put_addFollowerForAnotherUser_403(TestNamespace ns) { + DataProduct dataProduct = createEntity(createMinimalRequest(ns)); + + ForbiddenException exception = + assertThrows( + ForbiddenException.class, + () -> addFollower(SdkClients.user2Client(), dataProduct.getId(), testUser3().getId())); + + assertEquals(403, exception.getStatusCode()); + assertFalse(hasFollower(dataProduct.getId(), testUser3().getId())); + } + + @Test + void delete_followerForSelf_200(TestNamespace ns) { + DataProduct dataProduct = createEntity(createMinimalRequest(ns)); + OpenMetadataClient client = SdkClients.user2Client(); + UUID userId = testUser2().getId(); + + addFollower(client, dataProduct.getId(), userId); + assertTrue(hasFollower(dataProduct.getId(), userId)); + + deleteFollower(client, dataProduct.getId(), userId); + assertFalse(hasFollower(dataProduct.getId(), userId)); + } + + @Test + void delete_followerForAnotherUserAsAdmin_200(TestNamespace ns) { + DataProduct dataProduct = createEntity(createMinimalRequest(ns)); + OpenMetadataClient client = SdkClients.adminClient(); + UUID userId = testUser3().getId(); + + addFollower(client, dataProduct.getId(), userId); + assertTrue(hasFollower(dataProduct.getId(), userId)); + + deleteFollower(client, dataProduct.getId(), userId); + assertFalse(hasFollower(dataProduct.getId(), userId)); + } + + @Test + void put_addFollowerWithNullUserId_400(TestNamespace ns) { + DataProduct dataProduct = createEntity(createMinimalRequest(ns)); + + InvalidRequestException exception = + assertThrows( + InvalidRequestException.class, + () -> + SdkClients.user2Client() + .getHttpClient() + .execute( + HttpMethod.PUT, + "/v1/dataProducts/" + dataProduct.getId() + "/followers", + "null", + ChangeEvent.class, + RequestOptions.builder() + .header("Content-Type", "application/json") + .build())); + + assertEquals(400, exception.getStatusCode()); + assertEquals("userId is required", exception.getMessage()); + } + + @Test + void delete_removeFollowerForAnotherUser_403(TestNamespace ns) { + DataProduct dataProduct = createEntity(createMinimalRequest(ns)); + addFollower(SdkClients.user3Client(), dataProduct.getId(), testUser3().getId()); + + ForbiddenException exception = + assertThrows( + ForbiddenException.class, + () -> + deleteFollower(SdkClients.user2Client(), dataProduct.getId(), testUser3().getId())); + + assertEquals(403, exception.getStatusCode()); + assertTrue(hasFollower(dataProduct.getId(), testUser3().getId())); + } + + private void addFollower(OpenMetadataClient client, UUID dataProductId, UUID userId) { + client + .getHttpClient() + .execute( + HttpMethod.PUT, + "/v1/dataProducts/" + dataProductId + "/followers", + userId, + ChangeEvent.class); + } + + private void deleteFollower(OpenMetadataClient client, UUID dataProductId, UUID userId) { + client + .getHttpClient() + .execute( + HttpMethod.DELETE, + "/v1/dataProducts/" + dataProductId + "/followers/" + userId, + null, + ChangeEvent.class); + } + + private boolean hasFollower(UUID dataProductId, UUID userId) { + DataProduct dataProduct = getEntityWithFields(dataProductId.toString(), "followers"); + return dataProduct.getFollowers() != null + && dataProduct.getFollowers().stream() + .anyMatch(follower -> userId.equals(follower.getId())); + } + @Test void post_dataProductWithStyle_200_OK(TestNamespace ns) { OpenMetadataClient client = SdkClients.adminClient(); diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java index b9592b4bff66..84f7a650ce63 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java @@ -1791,8 +1791,9 @@ private ReadBundle buildReadBundle(T entity, ReadPlan readPlan) { return bundle; } - boolean onlyNonDeleted = isReadPlanNonDeletedOnly(readPlan); - CachedReadBundle bundleCache = onlyNonDeleted ? CacheBundle.getCachedReadBundle() : null; + boolean cacheReadBundle = + isReadPlanNonDeletedOnly(readPlan) && isCacheableEntityType(entityType); + CachedReadBundle bundleCache = cacheReadBundle ? CacheBundle.getCachedReadBundle() : null; java.util.concurrent.locks.Lock loadLock = null; CachedReadBundle.Dto initialDto = null; diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java index 0f2e87bef18d..568669c768db 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java @@ -46,6 +46,7 @@ import java.util.IdentityHashMap; import java.util.List; import java.util.Map; +import java.util.Objects; import java.util.Set; import java.util.TreeSet; import java.util.UUID; @@ -170,6 +171,32 @@ protected T addHref(UriInfo uriInfo, T entity) { } } + protected Response addFollowerInternal( + SecurityContext securityContext, UUID entityId, UUID userId) { + authorizeFollowerMutation(securityContext, userId); + return repository + .addFollower(securityContext.getUserPrincipal().getName(), entityId, userId) + .toResponse(); + } + + protected Response deleteFollowerInternal( + SecurityContext securityContext, UUID entityId, UUID userId) { + authorizeFollowerMutation(securityContext, userId); + return repository + .deleteFollower(securityContext.getUserPrincipal().getName(), entityId, userId) + .toResponse(); + } + + private void authorizeFollowerMutation(SecurityContext securityContext, UUID userId) { + if (userId == null) { + throw new BadRequestException("userId is required"); + } + SubjectContext subjectContext = getSubjectContext(securityContext); + if (!Objects.equals(subjectContext.user().getId(), userId)) { + authorizer.authorizeAdmin(securityContext); + } + } + protected List getEntitySpecificOperations() { return null; } diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIApplicationResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIApplicationResource.java index b8ba97e14283..75980ba0198e 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIApplicationResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIApplicationResource.java @@ -378,9 +378,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -409,9 +407,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIGovernancePolicyResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIGovernancePolicyResource.java index 98f1766b4c22..2e26598e6b9c 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIGovernancePolicyResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/AIGovernancePolicyResource.java @@ -360,9 +360,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -391,9 +389,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/LLMModelResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/LLMModelResource.java index 5130a0d2fd81..f0a3bb6ddcad 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/LLMModelResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/LLMModelResource.java @@ -362,9 +362,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -393,9 +391,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/McpServerResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/McpServerResource.java index f8cc97d4bdbb..3d771be5a312 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/McpServerResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/McpServerResource.java @@ -379,9 +379,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -410,9 +408,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/PromptTemplateResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/PromptTemplateResource.java index 416ec1d43bdb..82008dcb3d82 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/PromptTemplateResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/ai/PromptTemplateResource.java @@ -351,9 +351,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -382,9 +380,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/apis/APIEndpointResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/apis/APIEndpointResource.java index af1d5af51e83..d39c2aa46f4a 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/apis/APIEndpointResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/apis/APIEndpointResource.java @@ -531,9 +531,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -561,9 +559,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/charts/ChartResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/charts/ChartResource.java index da48c346f0cf..c1b5e492b195 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/charts/ChartResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/charts/ChartResource.java @@ -512,9 +512,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -533,9 +531,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @DELETE diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/dashboards/DashboardResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/dashboards/DashboardResource.java index a3db5e423c04..c80c6d6fb771 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/dashboards/DashboardResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/dashboards/DashboardResource.java @@ -527,9 +527,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -549,9 +547,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseResource.java index 976d90146c05..1c5c938609d9 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseResource.java @@ -950,9 +950,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -980,8 +978,6 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } } diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseSchemaResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseSchemaResource.java index 7957deed1004..3b17daf54aca 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseSchemaResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseSchemaResource.java @@ -401,9 +401,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -431,9 +429,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PATCH diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/StoredProcedureResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/StoredProcedureResource.java index 39751d9589fc..1007520bfbd4 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/StoredProcedureResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/StoredProcedureResource.java @@ -496,9 +496,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -526,9 +524,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/TableResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/TableResource.java index 64fc9b336ce7..734382452971 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/TableResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/TableResource.java @@ -892,9 +892,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @PUT @@ -1703,9 +1701,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/datamodels/DashboardDataModelResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/datamodels/DashboardDataModelResource.java index 9214bde60b80..35db974379b4 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/datamodels/DashboardDataModelResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/datamodels/DashboardDataModelResource.java @@ -530,9 +530,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -552,9 +550,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DataProductResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DataProductResource.java index d4872e75affe..5aa92dc93dd4 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DataProductResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DataProductResource.java @@ -994,9 +994,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -1023,9 +1021,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DomainResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DomainResource.java index 372a51cb4af4..a09293f3ae86 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DomainResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/domains/DomainResource.java @@ -699,9 +699,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -728,9 +726,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/DirectoryResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/DirectoryResource.java index 72079218a09c..7ad909755aef 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/DirectoryResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/DirectoryResource.java @@ -634,9 +634,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -665,9 +663,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/FileResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/FileResource.java index 8410633d2da5..64329e4aefa7 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/FileResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/FileResource.java @@ -642,9 +642,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -672,9 +670,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/SpreadsheetResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/SpreadsheetResource.java index b388e73f0c57..bd2d192f2ca0 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/SpreadsheetResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/SpreadsheetResource.java @@ -616,9 +616,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -647,9 +645,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/WorksheetResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/WorksheetResource.java index a8707487e7e6..056c2cf352e4 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/WorksheetResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/WorksheetResource.java @@ -592,9 +592,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -623,9 +621,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/knowledge/KnowledgePageResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/knowledge/KnowledgePageResource.java index e9d5e11f43eb..31f963957d1c 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/knowledge/KnowledgePageResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/knowledge/KnowledgePageResource.java @@ -684,9 +684,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @PUT @@ -742,9 +740,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/metrics/MetricResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/metrics/MetricResource.java index ee554fbd9bb9..1e4f809d56a1 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/metrics/MetricResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/metrics/MetricResource.java @@ -586,9 +586,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -615,9 +613,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/mlmodels/MlModelResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/mlmodels/MlModelResource.java index 46ef6c83cd92..5dd3a6cd93ec 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/mlmodels/MlModelResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/mlmodels/MlModelResource.java @@ -471,9 +471,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -502,9 +500,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/pipelines/PipelineResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/pipelines/PipelineResource.java index 879bc05f6671..c2ea9cc6ae0a 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/pipelines/PipelineResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/pipelines/PipelineResource.java @@ -722,9 +722,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -753,9 +751,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/query/QueryResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/query/QueryResource.java index 82cb93d22eee..e95a0cf1acb2 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/query/QueryResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/query/QueryResource.java @@ -471,9 +471,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @PUT @@ -528,9 +526,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/searchindex/SearchIndexResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/searchindex/SearchIndexResource.java index 48c4c9f3c951..b8a58a0dde95 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/searchindex/SearchIndexResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/searchindex/SearchIndexResource.java @@ -593,9 +593,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -623,9 +621,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/apiservices/APIServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/apiservices/APIServiceResource.java index b8555d192487..13bde8727561 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/apiservices/APIServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/apiservices/APIServiceResource.java @@ -581,9 +581,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -611,9 +609,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/dashboard/DashboardServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/dashboard/DashboardServiceResource.java index 5ebcc81c1391..2cdfbf4a1c91 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/dashboard/DashboardServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/dashboard/DashboardServiceResource.java @@ -215,9 +215,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -245,9 +243,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/database/DatabaseServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/database/DatabaseServiceResource.java index fc93f9384842..88e5813e57e3 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/database/DatabaseServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/database/DatabaseServiceResource.java @@ -437,9 +437,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -467,9 +465,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PATCH diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/drive/DriveServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/drive/DriveServiceResource.java index d31812fd1ade..73a4888df826 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/drive/DriveServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/drive/DriveServiceResource.java @@ -486,9 +486,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -517,9 +515,7 @@ public Response deleteFollower( schema = @Schema(type = "UUID")) @PathParam("userId") UUID userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return deleteFollowerInternal(securityContext, id, userId); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java index 8afc346f271b..15e48898814d 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java @@ -430,9 +430,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -460,9 +458,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/llm/LLMServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/llm/LLMServiceResource.java index f2fe8332044e..d398e71c3bca 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/llm/LLMServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/llm/LLMServiceResource.java @@ -420,9 +420,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -450,9 +448,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PATCH diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mcp/McpServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mcp/McpServiceResource.java index 826b5505f385..1fac0d01d042 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mcp/McpServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mcp/McpServiceResource.java @@ -413,9 +413,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -443,9 +441,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PATCH diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/messaging/MessagingServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/messaging/MessagingServiceResource.java index 5ac5acc91193..dee77c8aad22 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/messaging/MessagingServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/messaging/MessagingServiceResource.java @@ -294,9 +294,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -324,9 +322,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/metadata/MetadataServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/metadata/MetadataServiceResource.java index 9cab5010d6d8..07fd700242d5 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/metadata/MetadataServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/metadata/MetadataServiceResource.java @@ -308,9 +308,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -338,9 +336,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mlmodel/MlModelServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mlmodel/MlModelServiceResource.java index 1568140a2bf4..2a1289a09a64 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mlmodel/MlModelServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mlmodel/MlModelServiceResource.java @@ -280,9 +280,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -310,9 +308,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/pipeline/PipelineServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/pipeline/PipelineServiceResource.java index c8d79e38a3b5..7d829f1665a3 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/pipeline/PipelineServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/pipeline/PipelineServiceResource.java @@ -280,9 +280,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -310,9 +308,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/searchIndexes/SearchServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/searchIndexes/SearchServiceResource.java index 7d3b9adb9b6f..a25ad44eb616 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/searchIndexes/SearchServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/searchIndexes/SearchServiceResource.java @@ -298,9 +298,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -328,9 +326,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/security/SecurityServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/security/SecurityServiceResource.java index 1b86dd974a49..dbe410637a54 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/security/SecurityServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/security/SecurityServiceResource.java @@ -427,9 +427,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -457,9 +455,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PATCH diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/storage/StorageServiceResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/storage/StorageServiceResource.java index a9e24a8bdfc5..fcd8a7d2d98d 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/storage/StorageServiceResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/storage/StorageServiceResource.java @@ -264,9 +264,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "string")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -294,9 +292,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/storages/ContainerResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/storages/ContainerResource.java index e35460549ff9..c7aeec5436c3 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/storages/ContainerResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/storages/ContainerResource.java @@ -469,9 +469,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -500,12 +498,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower( - securityContext.getUserPrincipal().getName(), - UUID.fromString(id), - UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, UUID.fromString(id), UUID.fromString(userId)); } @GET diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/topics/TopicResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/topics/TopicResource.java index c68cdaea76ad..780dae80afed 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/topics/TopicResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/topics/TopicResource.java @@ -605,9 +605,7 @@ public Response addFollower( description = "Id of the user to be added as follower", schema = @Schema(type = "UUID")) UUID userId) { - return repository - .addFollower(securityContext.getUserPrincipal().getName(), id, userId) - .toResponse(); + return addFollowerInternal(securityContext, id, userId); } @DELETE @@ -634,9 +632,7 @@ public Response deleteFollower( schema = @Schema(type = "string")) @PathParam("userId") String userId) { - return repository - .deleteFollower(securityContext.getUserPrincipal().getName(), id, UUID.fromString(userId)) - .toResponse(); + return deleteFollowerInternal(securityContext, id, UUID.fromString(userId)); } @PUT