Throw client-safe errors for malformed date literals

DateScalar::parseLiteral passed the Carbon exception to
Error::createLocatedError, which keeps it as the error's previous.
Since InvalidFormatException is not ClientAware, that marked the error
as non-client-safe: the message was masked as "Internal server error"
and the exception was handed to the application's error reporter.

The variable path already rethrows without a previous via
tryParsingDate, so the same malformed value was a client error as a
variable but a server fault as a literal. Bring literals in line.

Author: arunarw

CHANGELOG.md

@@ -9,6 +9,10 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ## Unreleased
 
+### Fixed
+
+- Throw client-safe errors for malformed date literals instead of reporting them as server errors https://github.com/nuwave/lighthouse/pull/2788
+
 ## v6.70.0
 
 ### Changed

src/Schema/Types/Scalars/DateScalar.php

@@ -45,7 +45,7 @@ public function parseLiteral(Node $valueNode, ?array $variables = null): Illumin
         try {
             return $this->parse($value);
         } catch (\Exception $exception) {
-            throw Error::createLocatedError($exception, $valueNode);
+            throw new Error($exception->getMessage(), $valueNode);
         }
     }
 

tests/Unit/Schema/Types/Scalars/DateScalarTestBase.php

@@ -107,6 +107,25 @@ public function testThrowsIfParseLiteralNonString(): void
         );
     }
 
+    public function testThrowsClientSafeErrorIfParseLiteralInvalidDate(): void
+    {
+        $error = null;
+
+        try {
+            $this->scalarInstance()->parseLiteral(
+                new StringValueNode(['value' => 'rolf']),
+            );
+        } catch (Error $caught) {
+            $error = $caught;
+        }
+
+        $this->assertInstanceOf(Error::class, $error);
+        $this->assertTrue(
+            $error->isClientSafe(),
+            'A malformed date literal is client misuse, so it must not be reported as a server error.',
+        );
+    }
+
     public function testSerializesCarbonInstance(): void
     {
         $now = IlluminateCarbon::now();