Merge pull request #539 from netscaler/dnsglob

correcting GET url in global binding to include queryparameter args with type

Author: shivashankar-vaddepally

plugins/module_utils/common.py

@@ -13,6 +13,7 @@
     HTTP_RESOURCE_ALREADY_EXISTS,
     HTTP_RESOURCE_NOT_FOUND,
     HTTP_SUCCESS_CODES,
+    GLOBAL_BINDING_ARG_LIST
 )
 from .decorators import trace
 from .logger import log
@@ -61,11 +62,21 @@ def get_resource(client, resource_name, resource_id=None, resource_module_params
 
     if resource_name.endswith("_binding"):
         # binding resources require `filter` instead of `args` to uniquely identify a resource
-        status_code, response_body = client.get(
-            resource=resource_name,
-            id=resource_id,
-            filter=get_args,
-        )
+        if resource_name in GLOBAL_BINDING_ARG_LIST:
+            # here we are making sure that for globalbindings present in the list query params args=type and filter=get_arg_keys
+            del get_args["type"]
+            status_code, response_body = client.get(
+                resource=resource_name,
+                id=resource_id,
+                filter=get_args,
+                args={"type": resource_module_params["type"]},
+            )
+        else:
+            status_code, response_body = client.get(
+                resource=resource_name,
+                id=resource_id,
+                filter=get_args,
+            )
     elif resource_name in {"sslcertfile"}:
         status_code, response_body = client.get(
             resource=resource_name,

plugins/module_utils/constants.py

@@ -114,3 +114,24 @@
         fallback=(env_fallback, ["MANAGED_NETSCALER_INSTANCE_PASSWORD"]),
     ),
 )
+
+# this list contains globalbindings whose GET call must have query params args=type and filter=get_arg_keys (check in nitro_resource_map)
+GLOBAL_BINDING_ARG_LIST = [
+    'dnsglobal_dnspolicy_binding',
+    'responderglobal_responderpolicy_binding',
+    'contentinspectionglobal_contentinspectionpolicy_binding',
+    'appflowglobal_appflowpolicy_binding',
+    'appfwglobal_auditnslogpolicy_binding',
+    'appfwglobal_auditsyslogpolicy_binding',
+    'appfwglobal_appfwpolicy_binding',
+    'rewriteglobal_rewritepolicy_binding',
+    'transformglobal_transformpolicy_binding',
+    'sslglobal_sslpolicy_binding',
+    'tunnelglobal_tunneltrafficpolicy_binding',
+    'cmpglobal_cmppolicy_binding',
+    'feoglobal_feopolicy_binding',
+    'icaglobal_icapolicy_binding',
+    'lbglobal_lbpolicy_binding',
+    'cacheglobal_cachepolicy_binding',
+    'botglobal_botpolicy_binding',
+]