Skip to content

Commit d503629

Browse files
author
Shiva Shankar Vaddepally
committed
resolved lint issues
Signed-off-by: Shiva Shankar Vaddepally <shivashankar.vaddepally@cloud.com>
1 parent 84959c3 commit d503629

3 files changed

Lines changed: 35 additions & 27 deletions

File tree

examples/sslhsmkey.yaml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,13 @@
1-
21
---
32
- name: Create ssl hsm key
43
hosts: localhost
5-
gather_facts: no
4+
gather_facts: false
65
tasks:
76
- name: Create ssl hsm key
87
delegate_to: localhost
98
netscaler.adc.sslhsmkey:
9+
state: present
1010
hsmkeyname: "hsmk1"
1111
hsmtype: "SAFENET"
1212
serialnum: "116877xxxx465464"
1313
password: "xxxxxxx"
14-
register: result
15-
16-
- name: Debug result
17-
debug:
18-
var: result

plugins/module_utils/module_executor.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -500,15 +500,15 @@ def create_or_update(self):
500500
errorcode = None
501501
message = None
502502
err_str = str(err)
503-
m = re.search(r'status_code:\s*(\d+)', err_str)
504-
if m:
505-
status_code = int(m.group(1))
506-
m = re.search(r"'errorcode':\s*(\d+)", err_str)
507-
if m:
508-
errorcode = int(m.group(1))
509-
m = re.search(r"'message':\s*'([^']+)'", err_str)
510-
if m:
511-
message = m.group(1)
503+
regex_string = re.search(r'status_code:\s*(\d+)', err_str)
504+
if regex_string:
505+
status_code = int(regex_string.group(1))
506+
regex_string = re.search(r"'errorcode':\s*(\d+)", err_str)
507+
if regex_string:
508+
regex_string = int(regex_string.group(1))
509+
regex_string = re.search(r"'message':\s*'([^']+)'", err_str)
510+
if regex_string:
511+
message = regex_string.group(1)
512512
if not (
513513
status_code == 599 and
514514
errorcode == 1065 and
@@ -707,22 +707,22 @@ def delete(self):
707707
errorcode = None
708708
message = None
709709
err_str = str(err)
710-
m = re.search(r'status_code:\s*(\d+)', err_str)
711-
if m:
712-
status_code = int(m.group(1))
713-
m = re.search(r"'errorcode':\s*(\d+)", err_str)
714-
if m:
715-
errorcode = int(m.group(1))
716-
m = re.search(r"'message':\s*'([^']+)'", err_str)
717-
if m:
718-
message = m.group(1)
710+
regex_string = re.search(r'status_code:\s*(\d+)', err_str)
711+
if regex_string:
712+
status_code = int(regex_string.group(1))
713+
regex_string = re.search(r"'errorcode':\s*(\d+)", err_str)
714+
if regex_string:
715+
errorcode = int(regex_string.group(1))
716+
regex_string = re.search(r"'message':\s*'([^']+)'", err_str)
717+
if regex_string:
718+
message = regex_string.group(1)
719719
if not (
720720
status_code == 599 and
721721
errorcode == 1065 and
722722
message == "Internal error while adding HSM key."
723723
):
724724
self.return_failure(err)
725-
else:
725+
else:
726726
self.return_failure(err)
727727

728728
@trace
@@ -1248,4 +1248,4 @@ def main(self):
12481248
self.return_success()
12491249
except Exception as e:
12501250
msg = "Exception %s: %s" % (type(e), str(e))
1251-
self.return_failure(msg)
1251+
self.return_failure(msg)

plugins/modules/sslhsmkey.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,19 @@
8585
"""
8686

8787
EXAMPLES = r"""
88+
---
89+
- name: Create ssl hsm key
90+
hosts: localhost
91+
gather_facts: false
92+
tasks:
93+
- name: Create ssl hsm key
94+
delegate_to: localhost
95+
netscaler.adc.sslhsmkey:
96+
state: present
97+
hsmkeyname: "hsmk1"
98+
hsmtype: "SAFENET"
99+
serialnum: "116877xxxx465464"
100+
password: "xxxxxxx"
88101
"""
89102

90103
RETURN = r"""

0 commit comments

Comments
 (0)