supported only tasks variation

Signed-off-by: Shiva Shankar Vaddepally <shivashankar.vaddepally@cloud.com>

Author: Shiva Shankar Vaddepally

migrationtool/README.md

@@ -1,57 +1,57 @@
 # NetScaler ADC Ansible Collection Migration Tool
 
-Migrates Ansible playbooks from legacy `citrix.adc` collection to new `netscaler.adc` collection format.
+This tool helps migrate existing Ansible playbooks from the legacy `citrix.adc` collection to the new `netscaler.adc` collection format.
 
-## Usage
+## Overview
 
-```bash
-python3 convert_yaml.py -i input_playbook.yaml -o output_playbook.yaml
-```
+The migration tool converts YAML playbooks that use:
+- Legacy `citrix.adc` modules 
+- `citrix_adc_nitro_request` generic module
 
-**Arguments:**
-- `-i, --input`: (Required) Input YAML playbook
-- `-o, --output`: (Optional) Output file (defaults to `output.yaml`)
-- `-v, --verbose`: (Optional) Enable verbose output
+Into playbooks that use the new `netscaler.adc` collection modules.
 
-## What it converts
+## Features
 
-1. **Legacy modules**: `citrix.adc.lbvserver` → `netscaler.adc.lbvserver`
-2. **NITRO requests**: `citrix_adc_nitro_request` → specific resource modules
+- **Module Mapping**: Automatically maps legacy module names to new collection modules
+- **State Conversion**: Converts NITRO request operations to appropriate state values
+- **Credential Handling**: Preserves and converts authentication parameters
+- **YAML Structure Preservation**: Maintains playbook structure, variables, and task organization
 
-### Example Conversion
+## Usage
 
-**Before:**
-```yaml
-- name: Configure LB vserver
-  citrix_adc_nitro_request:
-    operation: present
-    resource: lbvserver
-    name: my_lb_vserver
-    attributes:
-      servicetype: HTTP
-      port: 80
-```
+### Basic Usage
 
-**After:**
-```yaml
-- name: Configure LB vserver
-  netscaler.adc.lbvserver:
-    state: present
-    name: my_lb_vserver
-    servicetype: HTTP
-    port: 80
+```bash
+python3 convert_yaml.py -i input_playbook.yaml -o output_playbook.yaml
 ```
 
-## Requirements
+### Arguments
+
+- `-i, --input`: (Required) Path to the input YAML playbook
+- `-o, --output`: (Optional) Path for the output file. Defaults to `output.yaml`
+
+### Example
 
 ```bash
-pip install pyyaml jinja2
+python convert_yaml.py -i legacy_playbook.yml -o migrated_playbook.yml
 ```
 
-## Files
+## Supported Conversions
 
-- `convert_yaml.py`: Main conversion script
-- `resourcelist.py`: Module and state mappings
+### Legacy Module Mappings
+The tool uses `resource_map` to convert legacy module names to new collection modules:
+- `citrix.adc.lbvserver` → `netscaler.adc.lbvserver`
+- `lbvserver` → `netscaler.adc.lbvserver`
+
+### NITRO Request Conversion
+Converts `citrix_adc_nitro_request` tasks to specific resource modules:
+
+**Before:**
+```yaml
+- name: Configure LB vserver
+  citrix_adc_nitro_request:
+    nsip: "{{ nsip }}"
+    nitro_user: "{{ nitro_user }}"
     nitro_pass: "{{ nitro_pass }}"
     operation: present
     resource: lbvserver

migrationtool/convert_yaml.py

@@ -39,15 +39,16 @@ def convert_yaml_file(input_file, output_file, template_file, verbose):
     # Convert input file (citrix.adc) to output file (citrix.adc.yaml) using template
     with open(input_file, 'r') as infile:
         data = yaml.safe_load(infile)
-    
+    task_only = False
     # Handle both list and dict formats
     if isinstance(data, list):
         # If data is a list, assume it's a list of plays/tasks
-        if len(data) > 0 and isinstance(data[0], dict):
+        if len(data) == 1 and isinstance(data[0], dict):
             # Take the first item if it's a dictionary
             play_data = data[0]
         else:
             # If it's a list of tasks, wrap it in a play structure
+            task_only = True
             play_data = {"tasks": data}
     elif isinstance(data, dict):
         play_data = data
@@ -124,16 +125,20 @@ def convert_yaml_file(input_file, output_file, template_file, verbose):
                 new_tasks.append(new_task)
 
     # Playbook struct
-    playbook = [{
-        "name": name,
-        "hosts": hosts,
-        "gather_facts": gather_facts,
-        "vars": vars_data,
-        "tasks": new_tasks
-    }]
+    if task_only:
+        playbook = new_tasks
+    else:
+        playbook = [{
+            "name": name,
+            "hosts": hosts,
+            "gather_facts": gather_facts,
+            "vars": vars_data,
+            "tasks": new_tasks
+        }]
 
     # Write the playbook directly as YAML without template
     with open(output_file, 'w') as outfile:
+        outfile.write("---\n")
         yaml.dump(playbook, outfile, default_flow_style=False, sort_keys=False, Dumper=CustomDumper, indent=2)
 
     print(f"Output written to: {output_file}")