Merge pull request #533 from netscaler/action_idem

Returning failure on action ops when netscaler return resource already error

Author: shivashankar-vaddepally

plugins/module_utils/module_executor.py

@@ -1020,11 +1020,16 @@ def act_on_resource(self, action):
             action=action,
         )
         if ok:
+            # For rename operations, always treat HTTP_RESOURCE_ALREADY_EXISTS as failure
+            # This prevents false positives where we think a rename succeeded when it actually
+            # failed due to a name conflict with a different existing resource
             if (
                 "status_code" in err
                 and err["status_code"] == HTTP_RESOURCE_ALREADY_EXISTS
             ):
                 self.module_result["changed"] = False
+                if action == "rename":
+                    self.return_failure(err)
         else:
             self.return_failure(err)
 

tests/integration/targets/gslbservice/tasks/main.yaml

@@ -113,27 +113,6 @@
     that:
       - "result.failed==false"
       - "result.changed==true"
-- name: GSLBSERVICE | RENAME | idempotent
-  delegate_to: localhost
-  register: result
-  check_mode: false
-  tags: test
-  netscaler.adc.gslbservice:
-    state: renamed
-    nsip: "{{ nsip }}"
-    nitro_user: "{{ nitro_user }}"
-    nitro_pass: "{{ nitro_pass }}"
-    nitro_protocol: "{{ nitro_protocol }}"
-    validate_certs: "{{ validate_certs }}"
-    save_config: "{{ save_config }}"
-    servicename: test-gslb-service
-    newname: test-gslb-service-renamed
-- name: Assert | GSLBSERVICE | RENAME | idempotent
-  tags: test
-  ansible.builtin.assert:
-    that:
-      - "result.failed==false"
-      - "result.changed==false"
 - name: GSLBSERVICE | DELETE | --check
   delegate_to: localhost
   register: result

tests/integration/targets/lbvserver/tasks/main.yaml

@@ -381,27 +381,6 @@
     that:
       - "result.failed==false"
       - "result.changed==true"
-- name: LBVSERVER | RENAME | idempotent
-  delegate_to: localhost
-  register: result
-  check_mode: false
-  tags: test
-  netscaler.adc.lbvserver:
-    nsip: "{{ nsip }}"
-    nitro_user: "{{ nitro_user }}"
-    nitro_pass: "{{ nitro_pass }}"
-    nitro_protocol: "{{ nitro_protocol }}"
-    validate_certs: "{{ validate_certs }}"
-    save_config: "{{ save_config }}"
-    state: renamed
-    name: lb1
-    newname: lb2
-- name: Assert | LBVSERVER | RENAME | idempotent
-  tags: test
-  ansible.builtin.assert:
-    that:
-      - "result.failed==false"
-      - "result.changed==false"
 - name: LBVSERVER | DELETE | --check
   delegate_to: localhost
   register: result

tests/integration/targets/service/tasks/main.yaml

@@ -108,27 +108,6 @@
     that:
       - "result.failed==false"
       - "result.changed==true"
-- name: SERVICE | RENAME | idempotent
-  delegate_to: localhost
-  register: result
-  check_mode: false
-  tags: test
-  netscaler.adc.service:
-    nsip: "{{ nsip }}"
-    nitro_user: "{{ nitro_user }}"
-    nitro_pass: "{{ nitro_pass }}"
-    nitro_protocol: "{{ nitro_protocol }}"
-    validate_certs: "{{ validate_certs }}"
-    save_config: "{{ save_config }}"
-    state: renamed
-    name: test-service
-    newname: test-service-renamed
-- name: Assert | SERVICE | RENAME | idempotent
-  tags: test
-  ansible.builtin.assert:
-    that:
-      - "result.failed==false"
-      - "result.changed==false"
 - name: SERVICE | DELETE | --check
   delegate_to: localhost
   register: result

tests/integration/targets/servicegroup/tasks/main.yaml

@@ -334,26 +334,6 @@
     that:
       - "result.failed==false"
       - "result.changed==true"
-- name: SERVICEGROUP | RENAME | idempotent
-  delegate_to: localhost
-  register: result
-  check_mode: false
-  tags: test
-  netscaler.adc.servicegroup:
-    nsip: "{{ nsip }}"
-    nitro_user: "{{ nitro_user }}"
-    nitro_pass: "{{ nitro_pass }}"
-    nitro_protocol: "{{ nitro_protocol }}"
-    validate_certs: "{{ validate_certs }}"
-    state: renamed
-    servicegroupname: "{{ servicegroup_name }}_renamed"
-    newname: "{{ servicegroup_name }}_renamed"
-- name: Assert | SERVICEGROUP | RENAME | idempotent
-  tags: test
-  ansible.builtin.assert:
-    that:
-      - "result.failed==false"
-      - "result.changed==false"
 - name: SERVICEGROUP | DELETE | --check
   delegate_to: localhost
   register: result