fix: remove unnecessary fallback and add edge case tests

- Remove `?? false` fallback on `optional` key since
  ArrayShapeType::getShape() guarantees its presence
- Add test cases for nested shapes, numeric keys, and nullable values
- Regenerate fixture with new test entities

Author: lacatoire

src/TypeDescriber/ArrayShapeDescriber.php

@@ -35,7 +35,7 @@ public function describe(Type $type, Schema $schema, array $context = []): void
             $property = Util::getProperty($schema, (string) $key);
             $this->describer->describe($shapeValue['type'], $property, $context);
 
-            if (!($shapeValue['optional'] ?? false)) {
+            if (!$shapeValue['optional']) {
                 $required[] = (string) $key;
             }
         }

tests/Functional/Entity/ArrayShapeTypes.php

@@ -20,4 +20,13 @@ class ArrayShapeTypes
 
     /** @var array{id: int, label: string, ...} */
     public array $unsealed;
+
+    /** @var array{user: array{name: string, age: int}, active: bool} */
+    public array $nested;
+
+    /** @var array{0: string, 1: int} */
+    public array $numericKeys;
+
+    /** @var array{name: ?string, email: ?string} */
+    public array $nullableValues;
 }

tests/Functional/Fixtures/ArrayShapeController.json

@@ -28,7 +28,10 @@
             "ArrayShapeTypes": {
                 "required": [
                     "sealed",
-                    "unsealed"
+                    "unsealed",
+                    "nested",
+                    "numericKeys",
+                    "nullableValues"
                 ],
                 "properties": {
                     "sealed": {
@@ -67,6 +70,69 @@
                         "additionalProperties": {
                             "nullable": true
                         }
+                    },
+                    "nested": {
+                        "required": [
+                            "active",
+                            "user"
+                        ],
+                        "properties": {
+                            "active": {
+                                "type": "boolean"
+                            },
+                            "user": {
+                                "required": [
+                                    "age",
+                                    "name"
+                                ],
+                                "properties": {
+                                    "age": {
+                                        "type": "integer"
+                                    },
+                                    "name": {
+                                        "type": "string"
+                                    }
+                                },
+                                "type": "object",
+                                "additionalProperties": false
+                            }
+                        },
+                        "type": "object",
+                        "additionalProperties": false
+                    },
+                    "numericKeys": {
+                        "required": [
+                            "0",
+                            "1"
+                        ],
+                        "properties": {
+                            "0": {
+                                "type": "string"
+                            },
+                            "1": {
+                                "type": "integer"
+                            }
+                        },
+                        "type": "object",
+                        "additionalProperties": false
+                    },
+                    "nullableValues": {
+                        "required": [
+                            "email",
+                            "name"
+                        ],
+                        "properties": {
+                            "email": {
+                                "type": "string",
+                                "nullable": true
+                            },
+                            "name": {
+                                "type": "string",
+                                "nullable": true
+                            }
+                        },
+                        "type": "object",
+                        "additionalProperties": false
                     }
                 },
                 "type": "object"