Skip to content

Commit 8afb3cf

Browse files
committed
Revert "feat(Option): Logfire (#88)"
This reverts commit 8600e12.
1 parent 8600e12 commit 8afb3cf

11 files changed

Lines changed: 8 additions & 77 deletions

File tree

docker-compose.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
services:
22
postgres:
33
image: postgres:17.4-bookworm
4-
hostname: postgres
5-
container_name: postgres
4+
hostname: forge
5+
container_name: forge
66
environment:
7-
POSTGRES_PASSWORD: postgres
8-
POSTGRES_USER: postgres
9-
POSTGRES_DB: postgres
7+
POSTGRES_PASSWORD: forge
8+
POSTGRES_USER: forge
9+
POSTGRES_DB: forge
1010
volumes:
1111
- ./init.sql:/docker-entrypoint-initdb.d/init.sql
1212
ports:
1313
- "5432:5432"
1414
restart: always
1515
healthcheck:
16-
test: pg_isready -U postgres
16+
test: pg_isready -U forge
1717
interval: 2s
1818
timeout: 3s
1919
retries: 40

fastapi_forge/example-projects/game_zone.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ project:
77
use_rabbitmq: true
88
use_taskiq: true
99
use_prometheus: true
10-
use_logfire: true
1110

1211
custom_enums:
1312
- name: UserRole

fastapi_forge/frontend/panels/project_config_panel.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,18 +206,13 @@ def _build(self) -> None:
206206
)
207207

208208
with ui.column().classes("w-full gap-2"):
209-
ui.label("Observability").classes("text-lg font-bold")
209+
ui.label("Metrics").classes("text-lg font-bold")
210210
self.use_prometheus = (
211211
ui.checkbox("Prometheus", value=state.use_prometheus)
212212
.classes("w-full")
213213
.bind_value_from(state, "use_prometheus")
214214
.tooltip("Collect and query metrics with Prometheus")
215215
)
216-
self.use_logfire = (
217-
ui.checkbox("Logfire", value=state.use_logfire)
218-
.classes("w-full")
219-
.bind_value_from(state, "use_logfire")
220-
)
221216

222217
with ui.column().classes("w-full gap-2"):
223218
ui.label("Object Storage").classes("text-lg font-bold")
@@ -252,7 +247,6 @@ def _bind_state_to_ui(self) -> None:
252247
)
253248
self.use_taskiq.bind_value_to(state, "use_taskiq")
254249
self.use_prometheus.bind_value_to(state, "use_prometheus")
255-
self.use_logfire.bind_value_to(state, "use_logfire")
256250

257251
def _update_taskiq_state(self, *_) -> None:
258252
"""Enable or disable Taskiq based on Redis and RabbitMQ."""
@@ -428,7 +422,6 @@ async def _create_project(self) -> None:
428422
state.use_rabbitmq = self.use_rabbitmq.value
429423
state.use_taskiq = self.use_taskiq.value
430424
state.use_prometheus = self.use_prometheus.value
431-
state.use_logfire = self.use_logfire.value
432425

433426
project_spec = state.get_project_spec()
434427
await build_fastapi_project(project_spec)

fastapi_forge/frontend/state.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ class ProjectState(BaseModel):
5555
use_rabbitmq: bool = False
5656
use_taskiq: bool = False
5757
use_prometheus: bool = False
58-
use_logfire: bool = False
5958

6059
def get_render_manager(self) -> RenderManager:
6160
"""Get the render manager for the current project."""
@@ -89,7 +88,6 @@ def initialize_from_project(self, project: ProjectSpec) -> None:
8988
self.use_rabbitmq = project.use_rabbitmq
9089
self.use_taskiq = project.use_taskiq
9190
self.use_prometheus = project.use_prometheus
92-
self.use_logfire = project.use_logfire
9391
self.models = project.models.copy()
9492
self.custom_enums = project.custom_enums.copy()
9593

@@ -205,7 +203,6 @@ def get_project_spec(self) -> ProjectSpec:
205203
use_rabbitmq=self.use_rabbitmq,
206204
use_taskiq=self.use_taskiq,
207205
use_prometheus=self.use_prometheus,
208-
use_logfire=self.use_logfire,
209206
models=self.models,
210207
custom_enums=self.custom_enums,
211208
)

fastapi_forge/schemas.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,6 @@ class ProjectSpec(_Base):
414414
use_rabbitmq: bool = False
415415
use_taskiq: bool = False
416416
use_prometheus: bool = False
417-
use_logfire: bool = False
418417
models: list[Model] = []
419418
custom_enums: list[CustomEnum] = []
420419

fastapi_forge/template/cookiecutter.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@
2323
"use_prometheus": {
2424
"default": true
2525
},
26-
"use_logfire": {
27-
"default": true
28-
},
2926
"models": {
3027
"models": []
3128
},

fastapi_forge/template/{{cookiecutter.project_name}}/.env.example

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,4 @@
3232
{% endif %}
3333
{%- if cookiecutter.use_prometheus %}
3434
{{ cookiecutter.project_name|upper|replace('-', '_') }}_PROMETHEUS_ENABLED=True
35-
{% endif %}
36-
{%- if cookiecutter.use_logfire %}
37-
{{ cookiecutter.project_name|upper|replace('-', '_') }}_LOGFIRE_ENABLED=True
38-
{{ cookiecutter.project_name|upper|replace('-', '_') }}_LOGFIRE_WRITE_TOKEN=""
3935
{% endif %}

fastapi_forge/template/{{cookiecutter.project_name}}/forge-config.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ paths:
3939
paths:
4040
- observability/prometheus
4141

42-
use_logfire:
43-
enabled: {{cookiecutter.use_logfire | lower}}
44-
paths:
45-
- observability/logfire
46-
4742
constants:
4843
requires_all:
4944
- use_builtin_auth
@@ -54,7 +49,6 @@ paths:
5449
observability:
5550
requires_all:
5651
- use_prometheus
57-
- use_logfire
5852
paths:
5953
- observability
6054

fastapi_forge/template/{{cookiecutter.project_name}}/pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ dependencies = [
4747
{%- if cookiecutter.use_prometheus -%}
4848
"prometheus-fastapi-instrumentator>=7.1.0",
4949
{%- endif %}
50-
{%- if cookiecutter.use_logfire -%}
51-
"logfire[aio-pika,asyncpg,fastapi,httpx,sqlalchemy,system-metrics]>=3.16.0",
52-
{%- endif %}
5350
]
5451

5552
[tool.pytest.ini_options]

fastapi_forge/template/{{cookiecutter.project_name}}/{{cookiecutter.project_name}}/middleware.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
{% if cookiecutter.use_prometheus %}
55
from prometheus_fastapi_instrumentator import Instrumentator
66
{% endif %}
7-
{% if cookiecutter.use_logfire %}
8-
import logfire
9-
from loguru import logger
10-
{% endif %}
117

128
def _add_cors_middleware(app: FastAPI) -> None:
139
"""Add CORS Middleware."""
@@ -19,27 +15,9 @@ def _add_prometheus_middleware(app: FastAPI) -> None:
1915
instrumenter = Instrumentator().instrument(app)
2016
instrumenter.expose(app)
2117
{% endif %}
22-
{% if cookiecutter.use_logfire %}
23-
def _add_logfire_middleware(app: FastAPI) -> None:
24-
"""Add Logfire Middleware."""
25-
if settings.logfire.enabled:
26-
logfire.configure(
27-
token=settings.logfire.write_token.get_secret_value(),
28-
environment=settings.env,
29-
send_to_logfire="if-token-present",
30-
service_name="{{ cookiecutter.project_name }}"
31-
)
32-
logfire.instrument_fastapi(app, capture_headers=True)
33-
logfire.instrument_asyncpg()
34-
logfire.instrument_system_metrics()
35-
logger.configure(handlers=[logfire.loguru_handler()])
36-
{% endif %}
3718
def add_middleware(app: FastAPI) -> None:
3819
"""Add all middlewares."""
3920
_add_cors_middleware(app)
4021
{%- if cookiecutter.use_prometheus %}
4122
_add_prometheus_middleware(app)
42-
{%- endif %}
43-
{%- if cookiecutter.use_logfire %}
44-
_add_logfire_middleware(app)
4523
{% endif %}

0 commit comments

Comments
 (0)