Merge pull request #3 from mrbrunelli/fix/empty-value

fix/empty-value

Author: mrbrunelli

lib/validate.js

@@ -24,14 +24,15 @@ class Validate {
       const [splicedField] = splitedFields.splice(0, 1)
       const joinedFields = splitedFields.join('.')
 
+      const existsValue = value !== undefined
       const existsMoreFields = !!joinedFields
       const existsFieldInObject = splicedField in object
 
       if (existsFieldInObject && existsMoreFields) {
         return Validate.isValid(object[splicedField], [[joinedFields, value]])
       }
 
-      const isNecessaryToCompareValues = !existsMoreFields && value
+      const isNecessaryToCompareValues = !existsMoreFields && existsValue
       if (isNecessaryToCompareValues) return value === object[splicedField]
 
       return existsFieldInObject && !existsMoreFields

lib/validate.spec.js

@@ -5,14 +5,16 @@ const makeObjectStub = () => {
     status: 200,
     data: {
       serviceName: 'DatasetSP.save',
-      error: '',
+      error: null,
       status: '1',
-      pendingPrinting: 'false',
+      pendingPrinting: false,
       transactionId: '6788329C5763C2982A9537E6DD1D122D',
       responseBody: {
-        total: '0',
+        total: 0,
         entities: {
-          entity: {}
+          entity: {
+            data: ''
+          }
         }
       }
     }
@@ -94,7 +96,10 @@ describe('validate', () => {
     const isValid = sut.isValid(objectStub, [
       ['status', 200],
       ['data.status', '1'],
-      ['data.responseBody.total', '0']
+      ['data.error', null],
+      ['data.pendingPrinting', false],
+      ['data.responseBody.total', 0],
+      ['data.responseBody.entities.entity.data', '']
     ])
     expect(isValid).toBeTruthy()
   })
@@ -112,4 +117,14 @@ describe('validate', () => {
     ])
     expect(isValid).toBeFalsy()
   })
+
+  test('should return false if provided field value is empty string, 0 or null and dont match with object value', () => {
+    const isValid = sut.isValid(objectStub, [
+      ['status', ''],
+      ['status', 0],
+      ['status', null],
+      ['status', false]
+    ])
+    expect(isValid).toBeFalsy()
+  })
 })

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mrbrunelli/object-validator",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "A simple object validator for tiny schemas",
   "main": "index.js",
   "scripts": {