Fixed small bug

Found why the DOMParser was not globally available - CJS works as ESM now.

Author: isimisi

base/display/metadata.js

@@ -18,22 +18,6 @@
 
 'use strict';
 
-// since this gets evaluated in pdfparser and DOMParser somehow does not exist in a CJS environment
-// we catch the error early and use @xmldom/xmldom DOMParser
-
-// Not exactly sure how DOMParser is available globally in a node environment in the first place
-// feel free to change this if a better method is to be found
-try {
-   var DomParser = DOMParser;
-} catch (error) {
-   if (typeof module === 'object' && typeof module.exports === 'object') {
-      // This is a CommonJS (CJS) environment
-      DomParser = require('@xmldom/xmldom').DOMParser;
-   } else {
-      throw error;
-   }
-}
-
 var Metadata = (PDFJS.Metadata = (function MetadataClosure() {
    function fixMetadata(meta) {
       return meta.replace(/>\\376\\377([^<]+)/g, function (all, codes) {
@@ -65,7 +49,7 @@ var Metadata = (PDFJS.Metadata = (function MetadataClosure() {
          // Ghostscript produces invalid metadata
          meta = fixMetadata(meta);
 
-         var parser = new DomParser();
+         var parser = new DOMParser();
          meta = parser.parseFromString(meta, 'application/xml');
       } else if (!(meta instanceof Document)) {
          error('Metadata: Invalid metadata object');

package.json

@@ -47,7 +47,8 @@
       "parse-e2": "node --trace-deprecation --trace-warnings pdf2json.js -f ./test/pdf/misc/i243_problem_file_anon.pdf -o ./test/target/misc",
       "parse-e3": "node --trace-deprecation --trace-warnings pdf2json.js -f ./test/pdf/misc/i200_test.pdf -o ./test/target/misc",
       "build:rollup": "rollup -c ./rollup.config.js",
-      "build": "npm run build:rollup"
+      "build:add-destructured-imports-to-cjs": "node rollup/addDestructedImports.js",
+      "build": "npm run build:rollup && npm run build:add-destructured-imports-to-cjs"
    },
    "engines": {
       "node": ">=18.12.1",
@@ -61,6 +62,8 @@
       "@xmldom/xmldom": "^0.8.8"
    },
    "devDependencies": {
+      "@rollup/plugin-commonjs": "^25.0.4",
+      "@rollup/plugin-node-resolve": "^15.2.1",
       "@rollup/plugin-replace": "^5.0.2",
       "@types/node": "^20.3.1",
       "lodash": "^4.17.21",