fix: imap idle writter with nil connection

plusiv · plusiv · commit d7a53ee15a38 · 2025-12-12T19:11:03.000-04:00
diff --git a/imap/idle.go b/imap/idle.go
@@ -21,7 +21,7 @@ func (c *conn) handleIdle(tag string) error {
 	}
 
 	done := make(chan struct{})
-	err := c.handler.Idle(&idleWriter{}, done, c.ctx)
+	err := c.handler.Idle(newIdleWriter(c.tpc), done, c.ctx)
 	if err != nil {
 		return err
 	}
@@ -57,6 +57,10 @@ type idleWriter struct {
 	tpc *textproto.Conn
 }
 
+func newIdleWriter(tpc *textproto.Conn) *idleWriter {
+	return &idleWriter{tpc: tpc}
+}
+
 func (w *idleWriter) WriteNumMessages(n uint32) error {
 	return w.tpc.PrintfLine("* %v EXISTS", n)
 }
@@ -66,5 +70,5 @@ func (w *idleWriter) WriteMessageFlags(msn uint32, flags []Flag) error {
 }
 
 func (w *idleWriter) WriteExpunge(msn uint32) error {
-	return w.tpc.PrintfLine("%v EXPUNGE", msn)
+	return w.tpc.PrintfLine("* %v EXPUNGE", msn)
 }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ func (c *conn) handleIdle(tag string) error {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`done := make(chan struct{})`
`24`		`- err := c.handler.Idle(&idleWriter{}, done, c.ctx)`
	`24`	`+ err := c.handler.Idle(newIdleWriter(c.tpc), done, c.ctx)`
`25`	`25`	`if err != nil {`
`26`	`26`	`return err`
`27`	`27`	`}`
`@@ -57,6 +57,10 @@ type idleWriter struct {`
`57`	`57`	`tpc *textproto.Conn`
`58`	`58`	`}`
`59`	`59`
	`60`	`+func newIdleWriter(tpc textproto.Conn) idleWriter {`
	`61`	`+ return &idleWriter{tpc: tpc}`
	`62`	`+}`
	`63`	`+`
`60`	`64`	`func (w *idleWriter) WriteNumMessages(n uint32) error {`
`61`	`65`	`return w.tpc.PrintfLine("* %v EXISTS", n)`
`62`	`66`	`}`
`@@ -66,5 +70,5 @@ func (w *idleWriter) WriteMessageFlags(msn uint32, flags []Flag) error {`
`66`	`70`	`}`
`67`	`71`
`68`	`72`	`func (w *idleWriter) WriteExpunge(msn uint32) error {`
`69`		`- return w.tpc.PrintfLine("%v EXPUNGE", msn)`
	`73`	`+ return w.tpc.PrintfLine("* %v EXPUNGE", msn)`
`70`	`74`	`}`