Merge pull request #59 from johanrd/deprecate-component-isVisible

Deprecate Component#isVisible

Author: statik

addon/components/ember-inline-editable.js

@@ -7,9 +7,8 @@ export default Component.extend({
   layout,
 
   classNames: ['ember-inline-editable'],
-  classNameBindings: [
-    'isVisible:is-visible:is-hidden',
-    'showEditButton:is-not-clickable'
-  ],
+  classNameBindings: ['showEditButton:is-not-clickable'],
+  shouldHide: false,
+  attributeBindings: ['shouldHide:hidden'],
   valueIsEmpty: computed.empty('value')
 })

addon/components/ember-inline-editor.js

@@ -15,7 +15,8 @@ const isInputField = el => {
 
 export default Component.extend({
   layout,
-  classNameBindings: ['isVisible:is-visible:is-hidden'],
+  shouldHide: false,
+  attributeBindings: ['shouldHide:hidden'],
 
   textFields: ['search', 'url', 'text', 'phone', 'email', 'number'],
   textAreaFields: ['textarea'],

addon/templates/components/ember-inline-edit.hbs

@@ -1,7 +1,7 @@
 {{#if (has-block-params)}}
   {{yield (hash
       editor=(component 'ember-inline-editor'
-        isVisible=isEditing
+        shouldHide=isNotEditing
         value=(readonly value)
         field=field
         fieldWidth=fieldWidth
@@ -20,7 +20,7 @@
         )
 
       editable=(component 'ember-inline-editable'
-        isVisible=isNotEditing
+        shouldHide=isEditing
         value=(readonly value)
         placeholder=placeholder
         showEditButton=showEditButton
@@ -33,7 +33,6 @@
 {{else}}
   {{#if isEditing}}
     {{ember-inline-editor
-      isVisible=isEditing
       value=(readonly value)
       field=field
       fieldWidth=fieldWidth
@@ -52,7 +51,6 @@
     }}
   {{else}}
     {{ember-inline-editable
-      isVisible=isNotEditing
       value=(readonly value)
       placeholder=placeholder
       editLabel=editLabel

tests/integration/components/ember-inline-edit-test.js

@@ -386,22 +386,22 @@ module('Integration | Component | ember inline edit', function(hooks) {
                     {{/ember-inline-edit}}`)
 
     assert.ok(
-      find('.editor').classList.contains('is-hidden'),
+      find('.editor').hasAttribute('hidden'),
       'editor is hidden by default'
     )
     assert.ok(
-      find('.editable').classList.contains('is-visible'),
+      !find('.editable').hasAttribute('hidden'),
       'editable is visible by default'
     )
 
     await click('.editor')
 
     assert.ok(
-      find('.editor').classList.contains('is-visible'),
+      !find('.editor').hasAttribute('hidden'),
       'editor is visible after click'
     )
     assert.ok(
-      find('.editable').classList.contains('is-hidden'),
+      find('.editable').hasAttribute('hidden'),
       'editable is hidden after click'
     )
   })