Skip to content

Commit 81333f4

Browse files
committed
1 parent 3a56882 commit 81333f4

4 files changed

Lines changed: 4431 additions & 1365 deletions

File tree

.eslintrc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
module.exports = {
22
root: true,
3+
parser: 'babel-eslint',
34
parserOptions: {
4-
ecmaVersion: 2017,
5+
ecmaVersion: 2019,
56
sourceType: 'module'
67
},
78
extends: 'eslint:recommended',

addon/components/ember-inline-edit.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import Component from '@ember/component'
22
import { set, computed } from '@ember/object'
33
import { htmlSafe } from '@ember/string'
44
import { run } from '@ember/runloop'
5-
import { tryInvoke } from '@ember/utils'
65

76
import layout from '../templates/components/ember-inline-edit'
87

@@ -90,16 +89,15 @@ export default Component.extend({
9089

9190
actions: {
9291
save() {
93-
tryInvoke(this, 'onSave', [this.value])
94-
92+
this.onSave?.(this.value);
9593
run(this, () => {
9694
set(this, 'isEditing', false)
9795
})
9896
},
9997

10098
startEditing(e) {
10199
e.stopPropagation()
102-
tryInvoke(this, 'onEdit')
100+
this.onEdit?.()
103101

104102
run(this, () => {
105103
set(this, 'previousValue', this.value)
@@ -108,7 +106,7 @@ export default Component.extend({
108106
},
109107

110108
cancel() {
111-
tryInvoke(this, 'onCancel')
109+
this.onCancel?.()
112110

113111
run(this, () => {
114112
set(this, 'value', this.previousValue)

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
"test:all": "ember try:each"
2525
},
2626
"dependencies": {
27-
"ember-cli-babel": "^6.6.0",
28-
"ember-cli-htmlbars": "^2.0.1"
27+
"ember-cli-babel": "^7.26.6",
28+
"ember-cli-htmlbars": "^5.7.1"
2929
},
3030
"devDependencies": {
31+
"babel-eslint": "^10.1.0",
3132
"broccoli-asset-rev": "^2.7.0",
3233
"ember-ajax": "^3.0.0",
33-
"ember-cli": "~3.3.0",
34+
"ember-cli": "~3.27.0",
3435
"ember-cli-dependency-checker": "^2.0.0",
35-
"ember-cli-eslint": "^4.2.1",
36+
"ember-cli-eslint": "^5.1.0",
3637
"ember-cli-github-pages": "^0.2.0",
37-
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
3838
"ember-cli-inject-live-reload": "^1.4.1",
3939
"ember-cli-qunit": "^4.3.2",
4040
"ember-cli-shims": "^1.2.0",
@@ -51,8 +51,8 @@
5151
"ember-source-channel-url": "^1.0.1",
5252
"ember-try": "^0.2.23",
5353
"ember-welcome-page": "^3.0.0",
54-
"eslint-plugin-ember": "^5.0.0",
55-
"eslint-plugin-node": "^6.0.1",
54+
"eslint-plugin-ember": "^10.5.3",
55+
"eslint-plugin-node": "^11.1.0",
5656
"loader.js": "^4.2.3",
5757
"qunit-dom": "^0.6.2"
5858
},

0 commit comments

Comments
 (0)