Deprecate Property Fallback Lookup (no-implicit-this)

See https://deprecations.emberjs.com/v3.x/#toc_has-block-and-has-block-params

Author: johanrd

addon/templates/components/ember-inline-edit.hbs

@@ -1,63 +1,64 @@
 {{#if hasBlockParams}}
   {{yield (hash
       editor=(component 'ember-inline-editor'
-        isVisible=isEditing
-        value=(readonly value)
-        field=field
-        fieldWidth=fieldWidth
-        showSaveButton=showSaveButton
-        showCancelButton=showCancelButton
-        saveLabel=saveLabel
-        cancelLabel=cancelLabel
-        editorClass=editorClass
-        buttonContainerClass=buttonContainerClass
-        saveButtonClass=saveButtonClass
-        cancelButtonClass=cancelButtonClass
-        hintLabel=hintLabel
-        on-update=(action (mut value))
+        isVisible=this.isEditing
+        value=(readonly this.value)
+        field=this.field
+        fieldWidth=this.fieldWidth
+        showSaveButton=this.showSaveButton
+        showCancelButton=this.showCancelButton
+        saveLabel=this.saveLabel
+        cancelLabel=this.cancelLabel
+        editorClass=this.editorClass
+        buttonContainerClass=this.buttonContainerClass
+        saveButtonClass=this.saveButtonClass
+        cancelButtonClass=this.cancelButtonClass
+        hintLabel=this.hintLabel
+        on-update=(action (mut this.value))
         on-save=(action "save")
         on-cancel=(action "cancel")
         )
 
       editable=(component 'ember-inline-editable'
-        isVisible=isNotEditing
-        value=(readonly value)
-        placeholder=placeholder
-        showEditButton=showEditButton
-        editButtonClass=editButtonClass
+        isVisible=this.isNotEditing
+        value=(readonly this.value)
+        placeholder=this.placeholder
+        showEditButton=this.showEditButton
+        editButtonClass=this.editButtonClass
         on-edit=(action "startEditing")
         )
       )
-    (action "save") (action "cancel")
+    (action "save")
+    (action "cancel")
     }}
 {{else}}
-  {{#if isEditing}}
+  {{#if this.isEditing}}
     {{ember-inline-editor
-      isVisible=isEditing
-      value=(readonly value)
-      field=field
-      fieldWidth=fieldWidth
-      showSaveButton=showSaveButton
-      showCancelButton=showCancelButton
-      saveLabel=saveLabel
-      cancelLabel=cancelLabel
-      editorClass=editorClass
-      buttonContainerClass=buttonContainerClass
-      saveButtonClass=saveButtonClass
-      cancelButtonClass=cancelButtonClass
-      hintLabel=hintLabel
-      on-update=(action (mut value))
+      isVisible=this.isEditing
+      value=(readonly this.value)
+      field=this.field
+      fieldWidth=this.fieldWidth
+      showSaveButton=this.showSaveButton
+      showCancelButton=this.showCancelButton
+      saveLabel=this.saveLabel
+      cancelLabel=this.cancelLabel
+      editorClass=this.editorClass
+      buttonContainerClass=this.buttonContainerClass
+      saveButtonClass=this.saveButtonClass
+      cancelButtonClass=this.cancelButtonClass
+      hintLabel=this.hintLabel
+      on-update=(action (mut this.value))
       on-save=(action "save")
       on-cancel=(action "cancel")
     }}
   {{else}}
     {{ember-inline-editable
-      isVisible=isNotEditing
-      value=(readonly value)
-      placeholder=placeholder
-      editLabel=editLabel
-      showEditButton=showEditButton
-      editButtonClass=editButtonClass
+      isVisible=this.isNotEditing
+      value=(readonly this.value)
+      placeholder=this.placeholder
+      editLabel=this.editLabel
+      showEditButton=this.showEditButton
+      editButtonClass=this.editButtonClass
       on-edit=(action "startEditing")
       }}
   {{/if}}

addon/templates/components/ember-inline-editable.hbs

@@ -1,17 +1,17 @@
 {{#if hasBlock}}
   {{yield}}
 {{else}}
-  {{#if valueIsEmpty}}
+  {{#if this.valueIsEmpty}}
     <span class="gray-text">
-      {{placeholder}}
+      {{this.placeholder}}
     </span>
   {{else}}
-    {{value}}
+    {{this.value}}
   {{/if}}
 
-  {{#if showEditButton}}
-    <span onclick={{action attrs.on-edit}} class="ember-inline-edit-toggle-btn {{editButtonClass}}">
-      {{editLabel}}
+  {{#if this.showEditButton}}
+    <span onclick={{action this.attrs.on-edit}} class="ember-inline-edit-toggle-btn {{this.editButtonClass}}">
+      {{this.editLabel}}
     </span>
   {{/if}}
 {{/if}}

addon/templates/components/ember-inline-editor.hbs

@@ -1,40 +1,40 @@
 {{#if hasBlock}}
   {{yield}}
 {{else}}
-  {{#if (in-arr textFields field)}}
+  {{#if (in-arr this.textFields this.field)}}
     <input
-      type={{field}}
-      value={{value}}
-      class="ember-inline-edit-input {{editorClass}}"
-      oninput={{action attrs.on-update value="target.value"}}
-      style={{fieldWidth}} />
-  {{else if (in-arr textAreaFields field)}}
+      type={{this.field}}
+      value={{this.value}}
+      class="ember-inline-edit-input {{this.editorClass}}"
+      oninput={{action this.attrs.on-update value="target.value"}}
+      style={{this.fieldWidth}} />
+  {{else if (in-arr this.textAreaFields this.field)}}
     <textarea
-      value={{value}}
-      class="ember-inline-edit-input {{editorClass}}"
-      oninput={{action attrs.on-update value="target.value"}}>
+      value={{this.value}}
+      class="ember-inline-edit-input {{this.editorClass}}"
+      oninput={{action this.attrs.on-update value="target.value"}}>
     </textarea>
   {{/if}}
 {{/if}}
 
-<div class="ember-inline-button-container {{buttonContainerClass}}">
-  {{#if showSaveButton}}
+<div class="ember-inline-button-container {{this.buttonContainerClass}}">
+  {{#if this.showSaveButton}}
     <button
-      {{action attrs.on-save bubbles=false}}
-      class="ember-inline-edit-save {{saveButtonClass}}">
-      {{saveLabel}}
+      {{action this.attrs.on-save bubbles=false}}
+      class="ember-inline-edit-save {{this.saveButtonClass}}">
+      {{this.saveLabel}}
     </button>
   {{/if}}
 
-  {{#if showCancelButton}}
+  {{#if this.showCancelButton}}
     <button
-      {{action attrs.on-cancel bubbles=false}}
-      class="ember-inline-edit-cancel {{cancelButtonClass}}">
-      {{cancelLabel}}
+      {{action this.attrs.on-cancel bubbles=false}}
+      class="ember-inline-edit-cancel {{this.cancelButtonClass}}">
+      {{this.cancelLabel}}
     </button>
   {{/if}}
 </div>
 
-{{#if hintLabel}}
-  <span class="hint">{{{hintLabel}}}</span>
+{{#if this.hintLabel}}
+  <span class="hint">{{{this.hintLabel}}}</span>
 {{/if}}