Update

Author: odow

src/FileFormats/MPS/read.jl

@@ -285,7 +285,9 @@ end
 Base.length(x::LineToItems) = x.nfields
 
 function Base.getindex(x::LineToItems, i::Int)
-    @assert 1 <= i <= x.nfields
+    if !(1 <= i <= min(5, x.nfields))
+        throw(BoundsError(x, i))
+    end
     return SubString(x.line, x.fields[i])
 end
 

test/FileFormats/MPS/test_MPS.jl

@@ -1729,6 +1729,61 @@ function test_unsupported_objectives()
     return
 end
 
+function test_LineToItems()
+    for line in [
+        "a",
+        " a ",
+        "a b",
+        " a b ",
+        "a b c",
+        " a b c ",
+        "a b c d",
+        " a b c d ",
+        "a b c d e",
+        " a b c d e ",
+    ]
+        @test collect(MPS.LineToItems(line)) ==
+              split(line, ' '; keepempty = false)
+    end
+    items = MPS.LineToItems("a b c d e f g")
+    @test length(items) == 7
+    @test_throws BoundsError items[0]
+    @test items[1] == "a"
+    @test_throws BoundsError items[6]
+    items = MPS.LineToItems("a b")
+    @test length(items) == 2
+    @test_throws BoundsError items[3]
+    return
+end
+
+function test_parse_header()
+    for (line, header) in [
+        "OBJSENSE" => MPS.HEADER_OBJSENSE,
+        "OBJSENSE MAX" => MPS.HEADER_OBJSENSE,
+        "ROWS" => MPS.HEADER_ROWS,
+        "COLUMNS" => MPS.HEADER_COLUMNS,
+        "RHS" => MPS.HEADER_RHS,
+        "RANGES" => MPS.HEADER_RANGES,
+        "BOUNDS" => MPS.HEADER_BOUNDS,
+        "SOS" => MPS.HEADER_SOS,
+        "ENDATA" => MPS.HEADER_ENDATA,
+        "QUADOBJ" => MPS.HEADER_QUADOBJ,
+        "QMATRIX" => MPS.HEADER_QMATRIX,
+        "QCMATRIX c" => MPS.HEADER_QCMATRIX,
+        "QSECTION c" => MPS.HEADER_QSECTION,
+        "INDICATORS" => MPS.HEADER_INDICATORS,
+        "" => MPS.HEADER_UNKNOWN,
+        "Foo" => MPS.HEADER_UNKNOWN,
+        "rhs x" => MPS.HEADER_UNKNOWN,
+    ]
+        items = MPS.LineToItems(line)
+        @test header == MPS.parse_header(items)
+        items = MPS.LineToItems(lowercase(line))
+        @test header == MPS.parse_header(items)
+    end
+    return
+end
+
 end  # TestMPS
 
 TestMPS.runtests()