Use ConstantCompare in EchCheckAcceptance

julek-wolfssl · julek-wolfssl · commit eaef83249412 · 2026-03-06T08:55:34.000+01:00
F-357
diff --git a/src/tls13.c b/src/tls13.c
@@ -4945,7 +4945,7 @@ static int EchCheckAcceptance(WOLFSSL* ssl, byte* label, word16 labelSz,
     }
     if (ret == 0) {
         /* last 8 bytes should match our expand output */
-        ret = XMEMCMP(acceptConfirmation, input + acceptOffset,
+        ret = ConstantCompare(acceptConfirmation, input + acceptOffset,
             ECH_ACCEPT_CONFIRMATION_SZ);
         /* ech accepted */
         if (ret == 0) {

Original file line number	Diff line number	Diff line change
`@@ -4945,7 +4945,7 @@ static int EchCheckAcceptance(WOLFSSL* ssl, byte* label, word16 labelSz,`
`4945`	`4945`	`}`
`4946`	`4946`	`if (ret == 0) {`
`4947`	`4947`	`/* last 8 bytes should match our expand output */`
`4948`		`- ret = XMEMCMP(acceptConfirmation, input + acceptOffset,`
	`4948`	`+ ret = ConstantCompare(acceptConfirmation, input + acceptOffset,`
`4949`	`4949`	`ECH_ACCEPT_CONFIRMATION_SZ);`
`4950`	`4950`	`/* ech accepted */`
`4951`	`4951`	`if (ret == 0) {`