plugin installation has to happen even in "dryRun" mode

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Author: ndeloof

plugin/src/main/java/io/jenkins/plugins/casc/plugins/PluginManagerConfigurator.java

@@ -77,27 +77,25 @@ protected PluginManager instance(Mapping mapping, ConfigurationContext context)
     }
 
     @Override
-    public PluginManager check(CNode c, ConfigurationContext context) throws ConfiguratorException {
-        return getTargetComponent(context);
-    }
+    protected void configure(Mapping config, PluginManager instance, boolean dryrun, ConfigurationContext context) throws ConfiguratorException {
+
+        // PluginManager has no dry-run mode : we need to actually install plugins, or we just can't check
+        // the other elements of the configuration regarding required plugins.
 
-    @Override
-    public PluginManager configure(CNode config, ConfigurationContext context) throws ConfiguratorException {
         Mapping map = config.asMapping();
         final Jenkins jenkins = Jenkins.getInstance();
 
         configureProxy(map, jenkins, context);
 
         final UpdateCenter updateCenter = configureUpdateSites(map, jenkins, context);
 
-        final PluginManager pluginManager = configurePlugins(map, jenkins, updateCenter, context);
+        configurePlugins(map, jenkins, updateCenter, context);
 
         try {
             jenkins.save();
         } catch (IOException e) {
             throw new ConfiguratorException("failed to save Jenkins configuration", e);
         }
-        return pluginManager;
     }
 
     private void configureProxy(Mapping map, Jenkins jenkins, ConfigurationContext context) throws ConfiguratorException {