Added a hint mode

- giving usage hints instead of classifying as anti-patterns

Author: jarulraj

src/checker.cpp

@@ -75,10 +75,11 @@ void Check(Configuration& state) {
   }
   else {
     std::cout << "\n==================== Summary ===================\n";
-    std::cout << "All Anti-Patterns  :: " << state.checker_stats[RISK_LEVEL_ALL] << "\n";
+    std::cout << "All Anti-Patterns and Hints  :: " << state.checker_stats[RISK_LEVEL_ALL] << "\n";
     std::cout << ">  High Risk   :: " << state.checker_stats[RISK_LEVEL_HIGH] << "\n";
     std::cout << ">  Medium Risk :: " << state.checker_stats[RISK_LEVEL_MEDIUM] << "\n";
     std::cout << ">  Low Risk    :: " << state.checker_stats[RISK_LEVEL_LOW] << "\n";
+    std::cout << ">  Hints       :: " << state.checker_stats[RISK_LEVEL_NONE] << "\n";
   }
 
   // Skip destroying std::cin

src/configuration.cpp

@@ -35,6 +35,8 @@ std::string RiskLevelToString(const RiskLevel& risk_level){
       return "MEDIUM RISK";
     case RISK_LEVEL_LOW:
       return "LOW RISK";
+    case RISK_LEVEL_NONE:
+      return "HINTS";
     case RISK_LEVEL_ALL:
       return "ALL ANTI-PATTERNS";
 
@@ -53,7 +55,9 @@ std::string RiskLevelToDetailedString(const RiskLevel& risk_level){
     case RISK_LEVEL_MEDIUM:
       return "ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS";
     case RISK_LEVEL_LOW:
-      return "ALL ANTI-PATTERNS";
+      return "ONLY ANTI-PATTERNS";
+    case RISK_LEVEL_NONE:
+      return "ALL ANTI-PATTERNS AND HINTS";
     case RISK_LEVEL_ALL:
       return "ALL ANTI-PATTERNS";
 

src/include/configuration.h

@@ -19,9 +19,10 @@ namespace sqlcheck {
 enum RiskLevel {
   RISK_LEVEL_INVALID = 10,
 
-  RISK_LEVEL_HIGH = 3,
-  RISK_LEVEL_MEDIUM = 2,
-  RISK_LEVEL_LOW = 1,
+  RISK_LEVEL_HIGH = 4,
+  RISK_LEVEL_MEDIUM = 3,
+  RISK_LEVEL_LOW = 2,
+  RISK_LEVEL_NONE = 1,
   RISK_LEVEL_ALL = 0
 
 };

src/list.cpp

@@ -599,7 +599,7 @@ void CheckNullUsage(Configuration& state,
                sql_statement,
                print_statement,
                pattern,
-               RISK_LEVEL_LOW,
+               RISK_LEVEL_NONE,
                pattern_type,
                title,
                message,
@@ -630,7 +630,7 @@ void CheckNotNullUsage(Configuration& state,
                sql_statement,
                print_statement,
                pattern,
-               RISK_LEVEL_MEDIUM,
+               RISK_LEVEL_NONE,
                pattern_type,
                title,
                message,