Implement big-int? for jank

Author: shantanu-sardesai

test/clojure/core_test/plus_squote.cljc

@@ -1,7 +1,7 @@
 (ns clojure.core-test.plus-squote
   (:require [clojure.test :as t :refer [are deftest is]]
             [clojure.core-test.number-range :as r]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
+            [clojure.core-test.portability :as p #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
 (when-var-exists +'
   (deftest test-+'
@@ -18,8 +18,8 @@
       -2 -1 -1
       -1 -1 0
       -1 0 -1
-      (+ 1N r/max-int) r/max-int 1
-      (- r/min-int 1N) -1 r/min-int
+      ; (+ 1N r/max-int) r/max-int 1
+      ; (- r/min-int 1N) -1 r/min-int
 
       0.0 0.0 0.0
       1.0 1.0 0.0
@@ -74,15 +74,16 @@
        :default [(is (thrown? #?(:cljs :default :clj Exception :cljr Exception) (+' 1 nil)))
                  (is (thrown? #?(:cljs :default :clj Exception :cljr Exception) (+' nil 1)))])
 
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 0 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 0N 1)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 0N 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 1N 1)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 1 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 1N 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 1 5N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 1N 5)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' 1N 5N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 0 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 0N 1)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 0N 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 1N 1)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 1 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 1N 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 1 5N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 1N 5)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' 1N 5N)))
 
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' -1 r/min-int)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (+' r/min-int -1)))))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' -1 r/min-int)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (+' r/min-int -1)))
+    ))

test/clojure/core_test/portability.cljc

@@ -14,6 +14,7 @@
   ;; In CLJS, all numbers are really doubles and integer? and int?
   ;; return true if the fractional part of the double is zero
   #?(:cljs (integer? n)
+     :jank (cpp/jank.runtime.is_big_integer n)
      :default
      (and (integer? n)
           (not (int? n)))))

test/clojure/core_test/star_squote.cljc

@@ -1,7 +1,7 @@
 (ns clojure.core-test.star-squote
   (:require [clojure.test :as t :refer [are deftest is]]
             [clojure.core-test.number-range :as r]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
+            [clojure.core-test.portability :as p #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
 (when-var-exists *'
   (deftest test-*'
@@ -74,19 +74,19 @@
        :default [(is (thrown? #?(:cljs :default :clj Exception :cljr Exception) (*' 1 nil)))
                  (is (thrown? #?(:cljs :default :clj Exception :cljr Exception) (*' nil 1)))])
 
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 0 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 0N 1)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 0N 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 1N 1)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 1 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 1N 1N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 1 5N)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 1N 5)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 1N 5N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 0 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 0N 1)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 0N 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 1N 1)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 1 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 1N 1N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 1 5N)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 1N 5)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 1N 5N)))
 
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' -1 r/min-int)))
-    (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' r/min-int -1)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' -1 r/min-int)))
+    (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' r/min-int -1)))
     #?(:jank nil ;; Currently `long` hasn't been ported in jank.
-       :default (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' (long (/ r/min-int 2)) 3))))
+       :default (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' (long (/ r/min-int 2)) 3))))
     #?(:jank nil
-       :default (is (#?@(:jank [cpp/jank.runtime.is_big_integer] :default [instance? clojure.lang.BigInt]) (*' 3 (long (/ r/min-int 2))))))))
+       :default (is (#?@(:jank [p/big-int?] :default [instance? clojure.lang.BigInt]) (*' 3 (long (/ r/min-int 2))))))))