Inside-out configuration from generic packs/packwiz

[ChipWolf]

Enhancement Type

Improve an existing feature

Describe the enhancement

I'd like a mechanism where the container is configured based on the content of the packwiz/generic pack.

For example, an .env file present in the generic pack could be used to set up environment variables, including the server TYPE etc. or, for packwiz packs, the values in the pack.toml could be used to select the server type/versioning.

This would mean when we ship our packs as artifacts, they don't depend on the outer configuration where a version bump would normally mean a breaking change for the pack consumer.

[itzg]

I could see this being possible in start-configuration where other calculations on VERSION are done and before TYPE is evaluated.

For generic packs could be a pair of inputs

• LOAD_ENV_FROM_ARCHIVE
• LOAD_ENV_FROM_FILE

With that it can source the contents into the env like applyResultsFile at

docker-minecraft-server/scripts/start-utils

Line 21 in d34111c

function applyResultsFile() {

[itzg]

@ChipWolf packwiz is already supported to some extent. Please a separate enhancement request to clarify what more is needed there.

[ChipWolf]

I realise this is sort of a dupe of my own 4 year old request #1439, I think the design in this issue would be easier to implement

[itzg]

Yes. I didn't even want to search for that issue to point out to you since that issue discussion was soul crushing. It was one of those that made me question the point of maintaining open source software.

Ignoring that (bad) trip down memory lane, your new issue narrows the scope tremendously and can be addressed on a very small scale and similar to one of the suggestions in that other issue discussion.

So, let's keep them separate.

[rhullah]

There is an existing issue to infer type/version/loader from packwiz: #1818. I think someone started to mess with it, but it doesn't look like it got anywhere.

[itzg]

Wow, I forgot all that discussion happened. That one is still the best place to track the packwiz enhancement.

Some day...

[itzg]

I'll plan on working on the generic pack support for this tomorrow evening.