Skip to content

Commit e682f0f

Browse files
committed
ci: fix workflow consistency and dry-run git configuration
- Make build verification consistent between workflows by using dynamic package discovery - Add git user configuration for dry-run to prevent changeset version errors - Remove hardcoded package paths in release.yml to match tests.yaml approach - Remove Node.js 18 from test matrix due to Firebase CLI v14 incompatibility
1 parent cb63460 commit e682f0f

2 files changed

Lines changed: 14 additions & 9 deletions

File tree

.github/workflows/release.yml

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,16 @@ jobs:
112112
- name: Verify build outputs
113113
run: |
114114
echo "Checking build outputs..."
115+
# Check all packages for dist directories
115116
MISSING_BUILDS=""
116-
117-
if [ ! -d "packages/react/dist" ]; then
118-
MISSING_BUILDS="$MISSING_BUILDS react"
119-
fi
120-
121-
if [ ! -d "packages/angular/dist" ]; then
122-
MISSING_BUILDS="$MISSING_BUILDS angular"
123-
fi
117+
for PKG_DIR in packages/*; do
118+
if [ -d "$PKG_DIR" ] && [ -f "$PKG_DIR/package.json" ]; then
119+
PKG_NAME=$(basename "$PKG_DIR")
120+
if [ ! -d "$PKG_DIR/dist" ]; then
121+
MISSING_BUILDS="$MISSING_BUILDS $PKG_NAME"
122+
fi
123+
fi
124+
done
124125
125126
if [ -n "$MISSING_BUILDS" ]; then
126127
echo "❌ Build outputs missing for: $MISSING_BUILDS"
@@ -175,6 +176,10 @@ jobs:
175176
done
176177
177178
echo "📦 Version changes that would be applied:"
179+
# Configure git user for changeset version command
180+
git config user.name "github-actions[bot]"
181+
git config user.email "github-actions[bot]@users.noreply.github.com"
182+
178183
# Save current HEAD reference before making changes
179184
ORIGINAL_HEAD=$(git rev-parse HEAD)
180185
# Create a temporary branch for dry run with unique name

.github/workflows/tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
needs: quality
5858
strategy:
5959
matrix:
60-
node-version: [18, 20, 22]
60+
node-version: [20, 22]
6161
steps:
6262
- name: Checkout code
6363
uses: actions/checkout@v4

0 commit comments

Comments
 (0)