Skip to content

Commit 8e18900

Browse files
authored
Merge pull request #2190 from Anonycoders/gh-pr-is-pull-request
fix: override GHPullRequest isPullRequest
2 parents a4a97a0 + f82b60e commit 8e18900

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

src/main/java/org/kohsuke/github/GHPullRequest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,16 @@ public boolean isMerged() throws IOException {
492492
return merged;
493493
}
494494

495+
/**
496+
* Since a GHPullRequest is always a pull request, this method always returns true.
497+
*
498+
* @return true
499+
*/
500+
@Override
501+
public boolean isPullRequest() {
502+
return true;
503+
}
504+
495505
/**
496506
* Retrieves all the commits associated to this pull request.
497507
*

src/test/java/org/kohsuke/github/GHEventPayloadTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,6 +1081,7 @@ public void pull_request() throws Exception {
10811081
assertThat(event.getPullRequest().getBase().getLabel(), is("baxterthehacker:main"));
10821082
assertThat(event.getPullRequest().getBase().getSha(), is("9049f1265b7d61be4a8904a9a27120d2064dab3b"));
10831083
assertThat(event.getPullRequest().isMerged(), is(false));
1084+
assertThat(event.getPullRequest().isPullRequest(), is(true));
10841085
assertThat(event.getPullRequest().getMergeable(), nullValue());
10851086
assertThat(event.getPullRequest().getMergeableState(), is("unknown"));
10861087
assertThat(event.getPullRequest().getMergedBy(), nullValue());

0 commit comments

Comments
 (0)