Merge pull request #20 from googlecodelabs/g3

Make js compiler happy

Author: ebidel

analytics-behavior.html

@@ -15,14 +15,14 @@
 -->
 
 <script>
+
+  var GoogleCodelabs = window.GoogleCodelabs || {};
+
   /**
    * `GoogleCodelabs.AnalyticsBehavior` implements Google Analytics functionality.
    *
    * @polymerBehavior GoogleCodelabs.AnalyticsBehavior
    */
-
-  GoogleCodelabs = window.GoogleCodelabs || {};
-
   GoogleCodelabs.AnalyticsBehavior = {
     listeners: {
       'google-codelab-step': '_trackStepChanged',
@@ -37,7 +37,7 @@
       params.hitType = hit;
       params.dimension1 = target.environment;
       params.dimension2 = target.category;
-      window.ga(function() {
+      window['ga'](function() {
         var trackers = ga.getAll();
         for (var i = 0; i < trackers.length; i++) {
           var tracker = trackers[i];

google-codelab-survey.html

@@ -86,7 +86,7 @@ <h4>How would rate your experience with Polymer?</h4>
       /**
        * Fired when user answers a survey question.
        * @event google-codelab-survey-answer
-       * @detail {{question: String, answer: String}}
+       * detail {{question: String, answer: String}}
        */
 
       properties: {
@@ -95,7 +95,10 @@ <h4>How would rate your experience with Polymer?</h4>
          * It is important to set this to a non-empty string
          * when hosting 2+ codelabs/surveys on the same domain.
          */
-        surveyId: '',
+        surveyId: {
+          type: String,
+          value: ''
+        },
 
         /**
          * All answers, synced with `localStorage`.
@@ -131,7 +134,7 @@ <h4>How would rate your experience with Polymer?</h4>
       _storageLoaded: function() {
         var elems = this.getContentChildren();
         var answer = '';
-        for (var i = 0; elem = elems[i]; i++) {
+        for (var i = 0, elem; elem = elems[i]; i++) {
           if (elem.tagName === 'H4') {
             answer = this.answers[this._elemText(elem)];
             continue;
@@ -143,6 +146,10 @@ <h4>How would rate your experience with Polymer?</h4>
         }
       },
 
+      /**
+       * @param {?} groupEl .
+       * @param {?=} value .
+       */
       _selectAnswer: function(groupEl, value) {
         for (var i = 0, elem; elem = groupEl.children[i]; i++) {
           if (!elem.name) {

google-codelab.html

@@ -177,7 +177,7 @@ <h2>Would you like to resume where you left off?</h2>
       /**
        * Fired when user advances a codelab step or goes backwards.
        * @event google-codelab-step
-       * @detail {{step: Object, index: Number}}
+       * detail {{step: Object, index: Number}}
        */
 
       /**
@@ -350,7 +350,7 @@ <h2>Would you like to resume where you left off?</h2>
       ready: function() {
         // TODO: cannot be done on prototype.
         // SEe https://github.com/PolymerElements/iron-a11y-keys-behavior/issues/19
-        this.keyEventTarget = document.body;
+        this.keyEventTarget = /** @type {!HTMLBodyElement} */(document.body);
 
         // select the step early, before localStorage is loaded
         this._updateStepIndexFromUrl();
@@ -410,7 +410,7 @@ <h2>Would you like to resume where you left off?</h2>
         var step = this.steps[this.selected];
         step.active = true;
 
-        location.hash = this.selected;
+        location.hash = this.selected.toString();
 
         this.fire('google-codelab-step', {index: this.selected, step: step});
 
@@ -447,7 +447,7 @@ <h2>Would you like to resume where you left off?</h2>
       },
 
       _updateStepIndexFromUrl: function() {
-        var step = parseInt(location.hash.slice(1));
+        var step = parseInt(location.hash.slice(1), 10);
         if (isNaN(step) || step < 0) {
           step = 0;
         }