Skip to content

Commit d4c11b3

Browse files
authored
ci: Classify fixtures/page_objects as test code (#123775)
Python files under `fixtures/page_objects/` are acceptance page-object helpers, but they currently match `backend_src`. This can add the backend scope and frontend/backend deployment warning to frontend pull requests that update acceptance coverage. Exclude `fixtures/page_objects/` from backend source classification and the normal backend test gate. Keep other Python fixtures in the existing backend classification and test selection. Acceptance and API-docs/OpenAPI checks continue to use their broader filters.
1 parent c02f796 commit d4c11b3

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

.github/file-filters.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,14 @@ backend_api_urls: &backend_api_urls
7878
- '**/urls.py'
7979

8080
# `backend_src` filters on files that are backend changes excluding
81-
# changes to the tests/ directory and changes to typescript related config files.
81+
# changes to tests/, acceptance page objects, and TypeScript-related config files.
8282
# If you want to filter on *all* backend files, use the `backend_all` filter.
8383
backend_src: &backend_src
8484
- *backend_build_changes
8585
- *backend_dependencies
86-
- '!(tests)/**/*.py'
86+
- '!(tests|fixtures)/**/*.py'
87+
- 'fixtures/*.py'
88+
- 'fixtures/!(page_objects)/**/*.py'
8789
- '**/*.sh'
8890
- '**/*.pysnap'
8991
- 'src/sentry/!(static)/**'
@@ -106,14 +108,16 @@ backend_all: &backend_all
106108
- '**/*.py'
107109
- '**/*.pyi'
108110

109-
# Like backend_all, but excludes tests/acceptance/ since those have their own
110-
# dedicated workflow (acceptance.yml) and are already --ignored by test-python-ci.
111+
# Like backend_all, but excludes tests/acceptance/ and fixtures/page_objects/.
112+
# Those are covered by acceptance.yml and are not part of test-python-ci.
111113
# Used by backend.yml to avoid triggering the full backend suite unnecessarily.
112114
backend_all_without_acceptance: &backend_all_without_acceptance
113115
- *backend_common
114116
- 'tests/!(acceptance)/**/*.{py,pyi}'
115117
- 'tests/*.py'
116-
- '!(tests)/**/*.pyi'
118+
- '!(tests|fixtures)/**/*.pyi'
119+
- 'fixtures/*.{py,pyi}'
120+
- 'fixtures/!(page_objects)/**/*.{py,pyi}'
117121

118122
# This is the ultimate controller for acceptance.yml
119123
acceptance: &acceptance

0 commit comments

Comments
 (0)