refactor(tests): rework active-job spec into shared spec#2941
Draft
refactor(tests): rework active-job spec into shared spec#2941
Conversation
Introduce sentry-rails/spec/active_job/ with the adapter-agnostic harness, FailingJob fixture, and composing shared example. No backend wiring yet — that lands in a follow-up. Refs #2933. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extend the harness drain helper to accept an at: keyword so backends that distinguish scheduled from immediate jobs can be drained deterministically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extend the harness with a configure_sentry hook so shared examples can override Sentry.init at make_basic_app time, then add a shared example asserting Job enqueued / Job performed structured log entries. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Every it block from spec/sentry/rails/activejob_spec.rb is now covered by a per-area shared example under spec/active_job/shared_examples/, exercised on the test adapter via spec/active_job/test_adapter_spec.rb. The named test_jobs.rb fixtures are kept in place for the legacy log-subscriber and Ruby 2.7 specs that still depend on them. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <copilot@github.com>
solnic
force-pushed
the
2933-new-spec-suite-for-active-job-integrations
branch
from
8c2b906 to
051beb7
Compare
solnic
force-pushed
the
2933-new-spec-suite-for-active-job-integrations
branch
from
051beb7 to
f72ae06
Compare
solnic
force-pushed
the
2933-new-spec-suite-for-active-job-integrations
branch
from
075cf25 to
1ba54c5
Compare
…m_enqueued_jobs at:)
solnic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is foundational work on a shared active-job spec that all AJ-backed backends will have to pass to be fully supported.
Refs #2933