Small clean up

Author: solnic

spec/features/tracing_spec.rb

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
 RSpec.describe "Tracing", type: :feature do
-  it "works", js: false do
+  it "works" do
     visit "/error"
 
     expect(page).to have_content("Svelte Mini App")
     expect(page).to have_button("Trigger Error")
+
     click_button "trigger-error-btn"
-    expect(page).to have_content("Error:")
 
-    events_data = get_rails_events
+    expect(page).to have_content("Error:")
 
-    expect(events_data[:event_count]).to be > 0
+    expect(logged_events[:event_count]).to be > 0
 
-    error_events = events_data[:events].select { |event| event["exception"] }
+    error_events = logged_events[:events].select { |event| event["exception"] }
     expect(error_events).not_to be_empty
 
     error_event = error_events.first
     exception_values = error_event.dig("exception", "values")
     expect(exception_values).not_to be_empty
     expect(exception_values.first["type"]).to eq("ZeroDivisionError")
 
-    transaction_events = events_data[:events].select { |event| event["type"] == "transaction" }
+    transaction_events = logged_events[:events].select { |event| event["type"] == "transaction" }
 
     expect(error_event.dig("contexts", "trace")).not_to be_nil
     error_trace_id = error_event.dig("contexts", "trace", "trace_id")
@@ -47,7 +47,7 @@
       end
     end
 
-    events_data[:envelopes].each do |envelope|
+    logged_events[:envelopes].each do |envelope|
       envelope["items"].each do |item|
         if item["payload"] && item["payload"]["_meta"] && item["payload"]["_meta"]["dsc"]
           dsc = item["payload"]["_meta"]["dsc"]

spec/support/test_helper.rb

@@ -4,29 +4,31 @@ module Test
   module Helper
     module_function
 
-    def get_rails_events
-      extracted_events = []
-      envelopes = []
+    def logged_events
+      @logged_events ||= begin
+        extracted_events = []
+        envelopes = []
 
-      logged_envelopes.each do |event_data|
-        envelopes << {
-          "headers" => event_data["envelope_headers"],
-          "items" => event_data["items"]
-        }
+        logged_envelopes.each do |event_data|
+          envelopes << {
+            "headers" => event_data["envelope_headers"],
+            "items" => event_data["items"]
+          }
 
-        event_data["items"].each do |item|
-          if item["headers"]["type"] == "event"
-            extracted_events << item["payload"]
+          event_data["items"].each do |item|
+            if item["headers"]["type"] == "event"
+              extracted_events << item["payload"]
+            end
           end
         end
-      end
 
-      {
-        events: extracted_events,
-        envelopes: envelopes,
-        event_count: extracted_events.length,
-        envelope_count: envelopes.length
-      }
+        {
+          events: extracted_events,
+          envelopes: envelopes,
+          event_count: extracted_events.length,
+          envelope_count: envelopes.length
+        }
+      end
     end
 
     def logged_envelopes